Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses several sources of “tech debt” affecting determinism and correctness in the compilation/codegen pipeline, and improves some APIs/tests around WASM output and translation.
Changes:
- Fix non-det void-block Drop emission to use the innermost (nested) block context during statement lowering.
- Update numeric literal lowering to select
i32.constvsi64.constbased on inferred literal type info. - Improve determinism of AST node iteration (sorting by node id) and adjust WASM→Rocq translation API to accept
&[u8], with related callsite/docs updates.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
core/wasm-codegen/src/compiler.rs |
Fix nested non-det Drop emission and add type-aware numeric literal lowering. |
tests/src/codegen/wasm/validation.rs |
Add regression tests intended to cover nested non-det blocks and i64-related behavior. |
core/ast/src/arena.rs |
Make node iteration deterministic by sorting by node id; add unit tests for ordering. |
core/inference/src/lib.rs |
Change wasm_to_v to accept &[u8] (and adjust implementation accordingly). |
core/inference/README.md |
Update public API documentation for wasm_to_v signature. |
core/cli/src/main.rs |
Avoid unnecessary cloning when calling wasm_to_v by passing a slice. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.