Skip to content

Fix tech dept#131

Merged
0xGeorgii merged 4 commits intomainfrom
fixing-known-bugs
Feb 19, 2026
Merged

Fix tech dept#131
0xGeorgii merged 4 commits intomainfrom
fixing-known-bugs

Conversation

@0xGeorgii
Copy link
Contributor

No description provided.

@0xGeorgii 0xGeorgii self-assigned this Feb 19, 2026
@0xGeorgii 0xGeorgii added bug Something isn't working refactoring Project supplements labels Feb 19, 2026
@0xGeorgii 0xGeorgii requested a review from Copilot February 19, 2026 09:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses several sources of “tech debt” affecting determinism and correctness in the compilation/codegen pipeline, and improves some APIs/tests around WASM output and translation.

Changes:

  • Fix non-det void-block Drop emission to use the innermost (nested) block context during statement lowering.
  • Update numeric literal lowering to select i32.const vs i64.const based on inferred literal type info.
  • Improve determinism of AST node iteration (sorting by node id) and adjust WASM→Rocq translation API to accept &[u8], with related callsite/docs updates.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
core/wasm-codegen/src/compiler.rs Fix nested non-det Drop emission and add type-aware numeric literal lowering.
tests/src/codegen/wasm/validation.rs Add regression tests intended to cover nested non-det blocks and i64-related behavior.
core/ast/src/arena.rs Make node iteration deterministic by sorting by node id; add unit tests for ordering.
core/inference/src/lib.rs Change wasm_to_v to accept &[u8] (and adjust implementation accordingly).
core/inference/README.md Update public API documentation for wasm_to_v signature.
core/cli/src/main.rs Avoid unnecessary cloning when calling wasm_to_v by passing a slice.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Inferara Inferara deleted a comment from codecov bot Feb 19, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 69.66292% with 54 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
core/wasm-codegen/src/compiler.rs 58.33% 50 Missing ⚠️
core/inference/src/lib.rs 0.00% 2 Missing ⚠️
core/ast/src/arena.rs 98.18% 1 Missing ⚠️
core/cli/src/main.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@0xGeorgii 0xGeorgii merged commit c61f7d9 into main Feb 19, 2026
6 checks passed
@0xGeorgii 0xGeorgii deleted the fixing-known-bugs branch February 19, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working refactoring Project supplements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments