Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Updates the infs CLI and related docs/tests to reflect the removal of LLVM tooling, narrowing toolchain management and health checks to the infc compiler binary.
Changes:
- Remove LLVM-related toolchain binaries/checks (
inf-llc,rust-lld,libLLVM) and update doctor/TUI/test expectations accordingly. - Simplify toolchain path/symlink management to a single managed binary (
infc) and update archive/scaffold/test utilities for the new layout. - Replace
randusage withfastrandand delete now-unused fixtures/helpers/APIs.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| editors/vscode/QA_GUIDE.md | Updates QA guidance/examples to match new toolchain warning scenarios. |
| apps/infs/tests/fixtures/type_error.inf | Removes unused fixture. |
| apps/infs/tests/cli_integration.rs | Updates doctor output assertions; removes redundant tests/helpers tied to removed fixtures/commands. |
| apps/infs/src/tui/widgets/mod.rs | Updates widget module docs to match current widget set. |
| apps/infs/src/tui/views/doctor_view.rs | Updates TUI doctor view tests to reflect infc-only checks. |
| apps/infs/src/tui/theme.rs | Removes unused theme field. |
| apps/infs/src/toolchain/resolver.rs | Switches to root-level infc resolution via binary_path. |
| apps/infs/src/toolchain/paths.rs | Reduces managed binaries to infc, simplifies binary_path, and updates symlink/validation logic + tests. |
| apps/infs/src/toolchain/manifest.rs | Removes unused manifest helper and test. |
| apps/infs/src/toolchain/download.rs | Replaces rand jitter with fastrand. |
| apps/infs/src/toolchain/doctor.rs | Removes LLVM checks and replaces generic binary checks with check_infc. |
| apps/infs/src/toolchain/conflict.rs | Limits PATH conflict detection docs/logic to managed infc and updates tests. |
| apps/infs/src/toolchain/archive.rs | Updates permission handling/tests to match infc root layout and removes LLVM artifacts from fixtures. |
| apps/infs/src/project/scaffold.rs | Removes unused convenience API and switches temp dir randomness to fastrand. |
| apps/infs/src/project/mod.rs | Removes unused re-exports tied to deleted APIs. |
| apps/infs/src/errors.rs | Removes unused typed error variants, retaining only process-exit propagation. |
| apps/infs/src/commands/doctor.rs | Updates command docs to reflect infc-only checks. |
| apps/infs/docs/qa-test-suite.md | Updates test counts and fixture list; refreshes last-updated date. |
| apps/infs/README.md | Updates docs to reflect only infc being symlinked. |
| apps/infs/Cargo.toml | Swaps rand dependency for fastrand. |
| CHANGELOG.md | Updates changelog wording to match infc-only symlinking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126