Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a "Hide Senders" feature that allows users to hide specific email senders from their view without deleting them. The hidden senders are stored persistently in Chrome local storage and can be managed through a new Settings modal. The PR also includes several CSS refactoring improvements, moving inline styles to CSS classes for better maintainability.
Changes:
- Added hide/unhide functionality with persistent storage per email account
- Integrated settings modal with theme selector and hidden senders management
- Refactored inline styles to CSS utility classes and dedicated stylesheets
- Added comprehensive test coverage for the hide senders feature
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| test/ui/sidebar/hideSenders.spec.ts | New comprehensive test suite for hide senders functionality |
| test/ui/sidebar/helpers.ts | Updated test helpers to support hide action |
| src/domain/repositories/storage_repo.ts | Added interface methods for storing/reading/removing hidden senders |
| src/data/repositories/chrome_local_storage_repo.ts | Implemented Chrome storage for hidden senders with account-specific persistence |
| src/data/repositories/mocks/mock_storage_repo.ts | Mock implementation for testing hidden senders functionality |
| src/presentation/providers/app_provider.tsx | Added state management and business logic for hiding/unhiding senders, filtering senders list |
| src/presentation/apps/sidebar/providers/modalContext.tsx | Extended modal types to include "hide" action |
| src/presentation/apps/sidebar/components/settingsModal.tsx | New settings modal with theme selector and hidden senders management |
| src/presentation/apps/sidebar/components/settingsModal.css | Styling for settings modal with theme-aware CSS variables |
| src/presentation/apps/sidebar/components/actionButton.tsx | Added hide button logic with direct action (no confirmation modal) |
| src/presentation/apps/sidebar/components/header.tsx | Added settings button and repositioned reload button to header |
| src/presentation/apps/sidebar/App.tsx | Integrated settings modal and hide button, removed separate theme toggle |
| src/presentation/apps/sidebar/App.css | Added utility classes (spacer-*, no-results-message) and new CSS variables |
| src/presentation/apps/sidebar/components/sendersContainer.tsx | Refactored inline styles to CSS class |
| src/presentation/apps/sidebar/components/senderLine.tsx | Simplified className construction |
| src/presentation/apps/sidebar/components/senderLine.css | Added utility classes for checkbox spacer and email count |
| src/presentation/apps/sidebar/components/reloadButton.css | Improved button styling and transitions |
| src/presentation/apps/sidebar/components/modalPopup.tsx | Replaced inline styles with utility classes |
| src/presentation/apps/sidebar/components/modalPopup.css | Improved CSS specificity to prevent style leakage |
| src/presentation/apps/sidebar/components/actionButton.css | Added styling for hide button, removed margin in favor of gap |
| src/presentation/apps/tutorial/components/steps.tsx | Replaced inline styles with CSS classes |
| src/presentation/apps/tutorial/Tutorial.css | Added CSS classes for success screen layout |
| src/presentation/apps/tutorial/index.css | Removed file (CSS variables moved to Tutorial.css or removed as unnecessary) |
| src/presentation/apps/popup/Popup.tsx | Moved inline styles to CSS |
| src/presentation/apps/popup/Popup.css | Added CSS for Gmail button positioning and icon sizing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
92a42cc to
e89cbb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12