Fix: Fractional Values Not Displayed Correctly Due to parseInt Usage #2
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Issue:
When using the ruler with fractional units (e.g., 0.1, 0.25), the displayed value doesn't update correctly. This happens because parseInt() is used on the value before rendering, which causes the fractional part to be discarded. As a result, values like 1.5 are parsed as 1, and the UI doesn't reflect the correct measurement.
Fix:
I replaced all instances of parseInt(prevValue.current) with Number(prevValue.current) and formatted the result using .toFixed(fractionDigits). This ensures that fractional values are preserved and displayed correctly in the ruler view.