Skip to content

Platform independent core - part 2#465

Open
Ingrim4 wants to merge 14 commits intomasterfrom
platform-core-v2
Open

Platform independent core - part 2#465
Ingrim4 wants to merge 14 commits intomasterfrom
platform-core-v2

Conversation

@Ingrim4
Copy link
Member

@Ingrim4 Ingrim4 commented Feb 1, 2026 •
edited
Loading

Description

  • use org.jspecify.annotations for nullability
  • move cache/obfuscate/player/proximity package to core
  • use sync + async listener for improved obfuscation speed
  • add support for chunk batch system
  • only force load chunks for obfsucation
  • add more statistics

Related Issue

Motivation and Context

Prepare project for multi platform (e.g. Paper, Fabric, ...) support.

How Has This Been Tested?

  • Successfully tested with every major spigot/paper version since 1.16.5

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

NgLoader
NgLoader previously approved these changes Feb 6, 2026
View reviewed changes
Copy link
Member

@NgLoader NgLoader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

orebfuscator-core/src/main/java/dev/imprex/orebfuscator/cache/CacheFileCleanupTask.java
@Override
public FileVisitResult postVisitDirectory(Path dir, @Nullable IOException exc) throws IOException {
try {
Files.delete(dir);
Copy link
Member

@NgLoader NgLoader Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that we are actually deleting the correct folder and not the root cache folder.

Ingrim4
Ingrim4 commented Feb 7, 2026
View reviewed changes
orebfuscator-core/src/main/java/dev/imprex/orebfuscator/config/AbstractWorldConfig.java
return;
}

// TODO: validate each height has some valid values or limit height or use some default fill in value
Copy link
Member Author

@Ingrim4 Ingrim4 Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

Ingrim4
Ingrim4 commented Feb 7, 2026
View reviewed changes
orebfuscator-core/src/main/java/dev/imprex/orebfuscator/proximity/ProximityWorker.java
BlockPos blockPos = proximityBlock.blockPos();

// skip lava obfuscated if not in lava
// TODO: the current deobfuscation would only deobfuscate lava if the neighboring block is a hiddenBlock
Copy link
Member Author

@Ingrim4 Ingrim4 Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

Ingrim4
Ingrim4 commented Feb 7, 2026
View reviewed changes
orebfuscator-core/src/main/java/dev/imprex/orebfuscator/util/WeightedRandom.java
int pick = random.nextDouble(totalWeight) < probabilities[i] ? i : alias[i];
int pick = boundedNextDouble(seed, totalWeight) < probabilities[i] ? i : alias[i];
return values[pick];
// int i = random.nextInt(this.n);
Copy link
Member Author

@Ingrim4 Ingrim4 Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate this custom random logic works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NgLoader NgLoader NgLoader left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ingrim4 @NgLoader