This repository was archived by the owner on Dec 10, 2023. It is now read-only.
fix(remix-pagination): preserve multiple values for search params#4
Open
mquinnv wants to merge 2 commits intoIgnisDa:mainfrom
Open
fix(remix-pagination): preserve multiple values for search params#4mquinnv wants to merge 2 commits intoIgnisDa:mainfrom
mquinnv wants to merge 2 commits intoIgnisDa:mainfrom
Conversation
…aram prior to this patch, URLSearchParams was being passed through Object.entries, which makes multiple values for the same param, e.g. q=3&q=4&q=5, be replaced with only one entry q=5. using URLSearchParams for the entire process of creating the page link (instead of the ufo library) resolves this problem
Owner
|
Thank you! It looks like this removes the |
Author
|
i think i did that properly. i've not used pnpm or this build system before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prior to this patch, URLSearchParams was being passed through Object.entries, which makes multiple values for the same param, e.g. q=3&q=4&q=5, be replaced with only one entry q=5. using URLSearchParams for the entire process of creating the page link (instead of the ufo library) resolves this problem
fixes #3