Skip to content

Increase default falling star height, add config to adjust height of where a falling star spawns.#9

Open
SpaceXCheeseWheel wants to merge 2 commits intoIdreesInc:masterfrom
SpaceXCheeseWheel:fallingStarHeight
Open

Increase default falling star height, add config to adjust height of where a falling star spawns.#9
SpaceXCheeseWheel wants to merge 2 commits intoIdreesInc:masterfrom
SpaceXCheeseWheel:fallingStarHeight

Conversation

@SpaceXCheeseWheel
Copy link

Fix for #8. Set the new default height to y=330 to compensate for increased terrain height in new versions of minecraft. Also, added a new config option "falling-stars-max-height" so this can be configured.
Note that with the new height, the speed at which the stars fell was sluggish, so I increased the speed as well.

@CloudeLecaw
Copy link

i looked in the config..
Could it be that this config of Version 2.0 is not up to date? The Setting falling-stars-max-height is no part of the config.yml...

@SpaceXCheeseWheel
Copy link
Author

falling-stars-max-height is a new configuration option I introduced, so its not in the plugin yet. Previously it was a hardcoded value.

@CloudeLecaw
Copy link

so i cant change it? :(

@SpaceXCheeseWheel
Copy link
Author

You can wait for IdreesInc to merge this PR, though that will take time. Otherwise, you can compile the plugin from my repository.

@CloudeLecaw
Copy link

CloudeLecaw commented Apr 12, 2023

i compiled your the version form your Repo and added the value

The "maximum" y level where a falling star can spawn

falling-stars-max-height: 320 to the config..
It looks like it does not work... the stars still fall down from 256 :3

The items apear at the first block seen but the animation starts at 256

@SpaceXCheeseWheel
Copy link
Author

I need to express my apologies, I completely forgot about this. Thank you for giving it a shot, though. You are probably very close, my best guess is that when you cloned my repository to your computer, you are working off of the wrong branch. My changes are on a branch called "fallingStarHeight", not the default "master."

Here's the file:
Celeste-SpXCheeseWheel.zip
As always, don't trust files from random people on the internet. If you want, I can still help you compile it yourself. Let me know.

@CloudeLecaw
Copy link

CloudeLecaw commented Apr 12, 2023

Your right i took the masters one D:
Thank you for pointing this out <3
It works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments