Increase default falling star height, add config to adjust height of where a falling star spawns.#9
Conversation
…ere the stars spawn close to earth,
|
i looked in the config.. |
|
falling-stars-max-height is a new configuration option I introduced, so its not in the plugin yet. Previously it was a hardcoded value. |
|
so i cant change it? :( |
|
You can wait for IdreesInc to merge this PR, though that will take time. Otherwise, you can compile the plugin from my repository. |
|
i compiled your the version form your Repo and added the value The "maximum" y level where a falling star can spawnfalling-stars-max-height: 320 to the config.. The items apear at the first block seen but the animation starts at 256 |
|
I need to express my apologies, I completely forgot about this. Thank you for giving it a shot, though. You are probably very close, my best guess is that when you cloned my repository to your computer, you are working off of the wrong branch. My changes are on a branch called "fallingStarHeight", not the default "master." Here's the file: |
|
Your right i took the masters one D: |
Fix for #8. Set the new default height to y=330 to compensate for increased terrain height in new versions of minecraft. Also, added a new config option "falling-stars-max-height" so this can be configured.
Note that with the new height, the speed at which the stars fell was sluggish, so I increased the speed as well.