NodeRemoveAction: Change display only if the removed node is a root node#479
Open
sukhwinder33445 wants to merge 1 commit intomainfrom
Open
NodeRemoveAction: Change display only if the removed node is a root node#479sukhwinder33445 wants to merge 1 commit intomainfrom
sukhwinder33445 wants to merge 1 commit intomainfrom
Conversation
Removing child nodes should not affect display of root nodes
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #460 by modifying the NodeRemoveAction class to only adjust display order when removing root nodes. Previously, the code would attempt to adjust display order for any removed node, but now it specifically checks if the removed node is a root node before performing display order adjustments.
- Adds a check to verify if the removed node is a root node before adjusting display order
- Removes unnecessary variable
$oldDisplayand replaces it with$removedNodeDisplay - Simplifies the logic by directly accessing the node's display value at the point of use
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Since I applied the patch I didn't get any Unbound nodes even if I used "Delete all occurrences of ...". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #460