Skip to content

Comments

Support custom ordering of nodes#384

Merged
nilmerg merged 7 commits intomasterfrom
feature/support-custom-ordering-252
Aug 3, 2023
Merged

Support custom ordering of nodes#384
nilmerg merged 7 commits intomasterfrom
feature/support-custom-ordering-252

Conversation

@nilmerg
Copy link
Member

@nilmerg nilmerg commented Jul 26, 2023 •
edited
Loading

resolves #252
closes #297

requires Icinga/ipl-web#173

@nilmerg nilmerg added enhancement New feature or improvement ref/NC labels Jul 26, 2023
@nilmerg nilmerg added this to the 2.5.0 milestone Jul 26, 2023
@nilmerg nilmerg self-assigned this Jul 26, 2023
@cla-bot cla-bot bot added the cla/signed label Jul 26, 2023
@nilmerg nilmerg force-pushed the feature/support-custom-ordering-252 branch from a714c81 to bb5b31e Compare July 26, 2023 15:32
@nilmerg
Copy link
Member Author

nilmerg commented Jul 26, 2023

Things to test:

  • Does the sort control work intuitively?
    • Especially in conjunction with manually ordered processes?
  • Do forms still work fine with respect to style and layout? (Didn't change, only somewhat technically)
  • Do process diffs look ... clean? (Add a new node, remove one, reorder something and look at the diff and evaluate whether there are unnecessary changes)

@flourish86
Copy link
Contributor

flourish86 commented Jul 27, 2023

The sorting works ok so far.

I'm sorry to say, but I discovered some problems, though.

  1. The first is meant to be addressed with the commit 954ef8b

It addresses a problem, where you had to click on the name to "enter" that node.

  1. The second problem is a result of that. Now the cursor won't indicate, that the tile would be draggable.

  2. There's still a delay (at least in Safari) until the tile will be draggable again, after being dragged and dropped.

@nilmerg nilmerg force-pushed the feature/support-custom-ordering-252 branch from 954ef8b to 36ad81a Compare July 28, 2023 06:32
@nilmerg
Copy link
Member Author

nilmerg commented Jul 28, 2023 •
edited
Loading

Okay. But this PR doesn't address anything related to drag and drop. I've pushed your changes separately: #385

@nilmerg nilmerg force-pushed the feature/support-custom-ordering-252 branch from 36ad81a to b5eef7a Compare July 28, 2023 06:52
@nilmerg nilmerg force-pushed the feature/support-custom-ordering-252 branch from b5eef7a to 0ac3320 Compare August 3, 2023 13:08
nilmerg added 2 commits August 3, 2023 15:19
@nilmerg
Use the new Sort trait where applicable
52c150c 
Moves the entire order processing to the renderers as that's
where it's mostly relevant. The only cases where nodes are
still ordered outside the rendering is where changes are
applied based on user input, which happened based on what's
been previously rendered.
@nilmerg
process/show: Allow to adjust the order of nodes
2acf611 
Nodes can be ordered as usually by display name, but now also
in descending order. They can now also be ordered by state.

This also applies to manually ordered processes. Though, changes
to the manual order can only happen if the default order is
active. If that's not the case, a note is shown and a way to reset
the sort order.
@nilmerg nilmerg force-pushed the feature/support-custom-ordering-252 branch from 0ac3320 to 2acf611 Compare August 3, 2023 13:19
@nilmerg nilmerg merged commit be1f56b into master Aug 3, 2023
@nilmerg nilmerg deleted the feature/support-custom-ordering-252 branch August 3, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nilmerg nilmerg

Labels

cla/signed enhancement New feature or improvement ref/NC

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

Possibility to sort nodes temporarily different

2 participants

@nilmerg @flourish86