Open
Conversation
nilmerg
requested changes
Aug 29, 2022
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
- The removal is still possible in tile view
- Editing a non-process node doesn't allow removal yet
raviks789
force-pushed
the
feature/delete-button-in-modify-view
branch
from
b7920fc to
4702eab
Compare
raviks789
force-pushed
the
feature/delete-button-in-modify-view
branch
from
4702eab to
d718311
Compare
nilmerg
reviewed
Sep 14, 2022
raviks789
force-pushed
the
feature/delete-button-in-modify-view
branch
from
d718311 to
fee17e1
Compare
raviks789
force-pushed
the
feature/delete-button-in-modify-view
branch
2 times, most recently
from
448da77 to
0df5226
Compare
sukhwinder33445
requested changes
Jul 24, 2023
raviks789
force-pushed
the
feature/delete-button-in-modify-view
branch
3 times, most recently
from
60b5622 to
6a0e373
Compare
sukhwinder33445
requested changes
Jul 24, 2023
raviks789
force-pushed
the
feature/delete-button-in-modify-view
branch
from
6a0e373 to
468f277
Compare
sukhwinder33445
previously approved these changes
Jul 25, 2023
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
The new Delete element only redirects, so why not just use an anchor button?
The modify view for the process form and edit node form must contain delete button. This allows the user to either store the modifications or delete the nodes.
Imported nodes will not have edit icon on their node tile. Hence, it is required to show the delete icon in their node tile. As the other nodes will have edit icon and their edit forms contain the delete button, it is not necessary to show the delete/cancel icon in their node tiles.
raviks789
force-pushed
the
feature/delete-button-in-modify-view
branch
from
468f277 to
5a18138
Compare
Contributor
There was a problem hiding this comment.
Shouldn't the delete button have some style @nilmerg @flourish86 ? I'm thinking of delete buttons in icingadb-web.
Contributor
Looks fine to me this way.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modify view for the process form and edit node form must contain delete button. This allows the user to either
store the modifications or delete the nodes.
ref #253