Sponsors#7
Conversation
need to slow down transition speed if possible or make continuous scroll
…her small sponsors. Issues: Not sure how to format the Adopters section on the prISUm site because they have names right below the logo with no link. Not sure if the name and company go together or not.
|
For future reference, you don't need to close the pull request and make a new one. All you need to do is commit and push to your fork again and BOOM, it's ready for re-review. If you check out your other PR, you'll see it's got your most recent commit at the bottom |
|
Also, in regards to your questions about the names in the adopters, you can remove the company logo from those. Last night they were telling me those were individual contributions, not company contributions. So it didn't make sense for the company to get their logo on there when they didn't donate anything. They really didn't know why they had them there in the first place. |
|
Ok that makes sense. Thanks for the quick response. And next time I will do the PR correctly lol Sent from my iPhone
|
There was a problem hiding this comment.
You can remove the stuff that used to be for the carousel, as in here and in the .js file since it's not needed. In general we would want to apply these to your sponsors.css file instead of modifying the bootstrap.css or bootstrap.js files. You would just add another class name in the html elements and give that class the extra style attributes in your sponsors.css file.
There was a problem hiding this comment.
For that, I meant to change it back because it didn't work anyways.
|
Yeah, for any bootstrap files, such as css, js or whatever else may have been changed, you can remove those changes. I originally was trying to slow down the transition speed and delay time, but since there is no longer any transitions happening, they can be removed. |
|
You'll need to do those changes and do another commit / push. We can't make changes to your branch. |
|
Right now the grid columns adjust width automatically with page width, but the pictures themselves don't adjust, leaving a smushed appearance. (See screenshot) We should shoot for something similar to the members page of the club website, where the columns bump down if the screen is resized too small. That will make it look nice for mobile devices too. It would be nice if the "grid cell" for each logo were the same size too, so they all line up nicely together.
|
|
Ok I'll try. This is all a learning process for me so I'll if I can get it to downsize better. If I'm slowing the clubs website production down at all, you can just move on lol. I just like getting the feedback and the learning experience. Sent from my iPhone
|
|
Hold off. Don't make any changes yet. This whole project might get scrapped. |
2 participants
Problem / Feature
Sponsors could all be seen at once.
Solution
Made into a grid
What To Test
Make sure all links work. Format any incorrect code. Figure out if Adopter names go with the pictures. for example, does Jon Dunn go with Wells Fargo, or is he a separate donor? On their site it seems that they go together but I am not sure. Still need to add Adopt a bettery sponsors and such.
Potentially change the colors of the titles if they are too juvenile or aren't a good color.
Reviewers
@CivBase @MichaelRupertDev
@Reviewer
FYI: @KrashLeviathan @csteamengine @regalcat