Open
Conversation
Author
|
Added |
Contributor
|
Ayush – That’s great! If you have Matlab so that you can test it there (maybe by running our validation suite), that’d be very helpful. At that point we should be ready to merge the PR.
From: Ayush Jamdar ***@***.***>
Sent: Monday, August 4, 2025 11:00 AM
To: ISET/iset3d-tiny ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [ISET/iset3d-tiny] Octave Support for ISET3D-Tiny (PR #4)
<https://avatars.githubusercontent.com/u/92583813?s=20&v=4> AyushJam left a comment (ISET/iset3d#4) <#4 (comment)>
Added isOctave tests wherever code differs for Octave. I've tested it on Octave 9.4.0, yet to test on Matlab.
—
Reply to this email directly, view it on GitHub <#4 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ4N3H2F4NE3Q43ZFNPDH33L6NRFAVCNFSM6AAAAACCKKQUPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNJRHAZTENJWGY> .
You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/ABJ4N3HONQE3K25ZY6GHWWD3L6NRFA5CNFSM6AAAAACCKKQUPWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTV33US7M.gif> Message ID: ***@***.*** ***@***.***> >
|
Author
|
Working on it right now, please correct me if I'm wrong, I believe the script I put together |
Author
|
I tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While ISET is an amazing simulation tool, it depends on its user's having paid MATLAB licenses which might not be accessible to all individuals and organizations interested in using the toolbox.
GNU Octave is a free and open-source alternative for MATLAB. It imitates most MATLAB functionality with code and CLI but has different libraries, toolboxes, and datatypes. One third-party package of importance in
isethdrsensorisopenexr. With help from Brian and David, I was able to modify the current ISET codebase to work with Octave 6.4.0.The changes are briefly described at the end of
README.mdand the necessary packages are listed in another PR opened in theisetcamrepository.This PR goes along with the two others opened in
isetcamandisethdrsensorrepos. All these branches are nameddev-octave.I have tested this code on Octave 6.4.0 using a conda environment as detailed in
isetcam/environment.yml.Hope this helps extend access to ISET!