Skip to content

Gdcc/Signposting#8981

Merged
kcondon merged 140 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:GDCC/Signposting
Mar 24, 2023
Merged

Gdcc/Signposting#8981
kcondon merged 140 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:GDCC/Signposting

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Sep 16, 2022

What this PR does / why we need it: This is an update of/replacement for #8424. The original author was unable to continue development to address review comments.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:
This PR does not change any human readable part of Dataverse.

curl -I http://linkto.dataverse/dataset to see the signposting L1 header

Link to L2 linkset can be found in L1 header and can be directly viewed in browser

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: release note

Additional documentation:
new discoverability page in admin guide

Vic Ding and others added 30 commits November 4, 2020 12:32
* uses external js
* adding signposting configuration setting
* signposting poc from eko
* error fix
* move the signposting location in code
* Signposting with MicroSettings cleanup v1 xhtml revert to vanilla
* clean up
* bug fix and add default file type; TODO: Bug on the baseurl (empty string)
* hide type when do not use default
* set default when no config is set for signposting
* modification according to reviews
* move long json string from code to bunddle
* allow empty config on the level 2 profile

Co-authored-by: Kevin Condon <kcondon@hmdc.harvard.edu>
Co-authored-by: ekoi <eko.indarto@dans.knaw.nl>
@qqmyers qqmyers removed their assignment Mar 21, 2023
@pdurbin pdurbin self-assigned this Mar 22, 2023
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for all the improvements, @qqmyers.

I did push a small tweak to the docs.

Approved.

@pdurbin pdurbin removed their assignment Mar 22, 2023
@kcondon kcondon self-assigned this Mar 22, 2023
@kcondon
Copy link
Contributor

kcondon commented Mar 24, 2023

Issues found:

  1. lots of signpost logging (fixed) logging had been left on
    pub_dataset_signpost_on.txt

  2. perhaps mistake in signpost content, file/ds link mixup (n/a) was confusion on my part, comma is separator
    signpost_request_ds_header.txt

  3. signpost err in log (n/a) this was likely due to a corrupted dataset resulting from testing delete file api. I removed that dataset and do not see the error.
    signpost_log_err.txt

@kcondon kcondon merged commit 89c5add into IQSS:develop Mar 24, 2023
@pdurbin pdurbin mentioned this pull request Oct 3, 2023
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
@cmbz cmbz added FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) and removed FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) Size: 10 A percentage of a sprint. 7 hours.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Signposting support in Dataverse