Skip to content

Experimental: ignore non-explicit groups (IP groups, specifically) when making solr queries #12149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
landreev wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Experimental: ignore non-explicit groups (IP groups, specifically) when making solr queries #12149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe69463
FeatureFlags (for "skip non-explicit groups")
landreev Aug 13, 2024
cc9e23f
A local mod that skips non-explicit groups when the corresponding fla…
landreev Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/main/java/edu/harvard/iq/dataverse/search/SolrSearchServiceBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,14 @@ private String getPermissionFilterQuery(DataverseRequest dataverseRequest, SolrQ
for (Group group : groups) {
String groupAlias = group.getAlias();
if (groupAlias != null && !groupAlias.isEmpty() && (!avoidJoin || !groupAlias.startsWith("builtIn"))) {
groupList.add(IndexServiceBean.getGroupPrefix() + groupAlias);
boolean skipThisGroup = false;
if (FeatureFlags.SKIP_NONEXPLICIT_GROUPS.enabled() && group.getGroupProvider() != null && !"explicit".equals(group.getGroupProvider().getGroupProviderAlias())) {
skipThisGroup = true;
logger.info("Skipping non-explicit group " + groupAlias);
}
if (!skipThisGroup) {
groupList.add(IndexServiceBean.getGroupPrefix() + groupAlias);
}
}
}

Expand Down
1 change: 1 addition & 0 deletions src/main/java/edu/harvard/iq/dataverse/settings/FeatureFlags.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ public enum FeatureFlags {
* @since Dataverse 6.3
*/
ADD_PUBLICOBJECT_SOLR_FIELD("add-publicobject-solr-field"),
SKIP_NONEXPLICIT_GROUPS("skip-nonexplicit-groups"),
/**
* With this flag set, Dataverse will index the actual origin of harvested
* metadata records, instead of the "Harvested" string in all cases.
Expand Down
Loading