Skip to content

Improve PID update performance #12121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qqmyers wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve PID update performance #12121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...n/java/edu/harvard/iq/dataverse/engine/command/impl/UpdateDvObjectPIDMetadataCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
@RequiredPermissions({})
public class UpdateDvObjectPIDMetadataCommand extends AbstractVoidCommand {

private final Dataset target;
private Dataset target;

public UpdateDvObjectPIDMetadataCommand(Dataset target, DataverseRequest aRequest) {
super(aRequest, target);
Expand All @@ -53,8 +53,7 @@ protected void executeImpl(CommandContext ctxt) throws CommandException {
Boolean doiRetString = pidProvider.updateIdentifier(target);
if (doiRetString) {
target.setGlobalIdCreateTime(new Timestamp(new Date().getTime()));
ctxt.em().merge(target);
ctxt.em().flush();
target = ctxt.em().merge(target);
// When updating, we want to traverse through files even if the dataset itself
// didn't need updating.
boolean isFilePIDsEnabled = ctxt.systemConfig().isFilePIDsEnabledForCollection(target.getOwner());
Expand All @@ -75,8 +74,6 @@ protected void executeImpl(CommandContext ctxt) throws CommandException {
doiRetString = pidProvider.updateIdentifier(df);
if (doiRetString) {
df.setGlobalIdCreateTime(new Timestamp(new Date().getTime()));
ctxt.em().merge(df);
ctxt.em().flush();
}
}
}
Expand Down