IQSS/8690 Make producer optional #11995
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR makes the change suggested in #8690 to not require the producerName so that the producer field becomes optional.
Which issue(s) this PR closes:
Special notes for your reviewer: There's discussion in the issue. If we want to set producerName to not be required at the block level, this PR will do it. (Probably should include a release note w.r.t. how to set it to required at the root Dataverse level if you want for backward compatibility, and with the usual instructions for updating the block. Happy to add that when I get back.)
Suggestions on how to test this: Testing requires a fix for #11992 - e.g. PR #12017 .Once that is available/merged, you should be able to check in the UI that it is now possible to uncheck the Producer field on a given Dataverse and verify that the field no longer shows for datasets created within it.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: