Storage Quota/Upload Limit Integration #921
Open
+237
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GREI Re-arch
ekraffmiller
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
Contributor
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
Looks good & works really nicely! just a couple of comments.
Contributor
There was a problem hiding this comment.
This should use the DatasetRepository, rather than directly calling the jsDataverse function
Contributor
There was a problem hiding this comment.
It would be good to have a FileUploadInput story that shows the file upload limit messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Show storage/file quotas on the Upload Files page
Which issue(s) this PR closes:
Special notes for your reviewer:
Test coverage did not meet the 95% threshold. I’ve addressed the coverage issue in the Manage Template PR and will recheck this once that PR is merged. Since I already added some tests in this PR, I’m leaving it as-is for now, feel free to ignore the test failure and proceed with the review if you’d like.
package.json should be updated to alpha
I expect the upload limits will have more fields, but for now, it shows Storage Quota only
When the file exceeds the storage quota, it would raise an error. It has been implemented before.
Suggestions on how to test this:
PUT http://localhost:8000/api/v1/admin/settings/:UseStorageQuotasPUT http://localhost:8000/api/datasets/:persistentId/storage/quota?persistentId={...}Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes, a screenshot above
Is there a release notes or changelog update needed for this change?:
Yes, changelog should be updated
Additional documentation: