Skip to content

Conversation

@ChengShi-1
Copy link
Contributor

@ChengShi-1 ChengShi-1 commented Jan 14, 2026

What this PR does / why we need it

We have api and use cases for get/create/delete template, we are able to integrate things related to these use cases.
Collection page -> Edit button -> Dataset Templates

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Empty State
image

Create Dataset Template
image

After creating it successfully, it's supposed to jump to Edit Terms page, but because of a lack of API now, we cannot edit terms here, but I have a mock page here.
image

Manage Templates ( you could sort the list by name, date and usage, if you click the table's headers)
PS, make a default, edit templates are not implemented
image

When you click the "eye"(view) icon, there is a modal of Dataset Template Preview
image

When you click the Delete icon, there is a modal of Delete Template
image

When you click copy, it should give you a copy template and refresh the table automatically so you could see it soon.

Create a nested collection inside Root collection, you will have a Edit permission to current collection, and only view permission to root collection's templates.
image

Is there a release notes or changelog update needed for this change?:

Yes

Additional documentation:

@ChengShi-1 ChengShi-1 linked an issue Jan 14, 2026 that may be closed by this pull request
@github-actions github-actions bot added FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) GREI Re-arch GREI re-architecture-related SPA labels Jan 14, 2026
@ChengShi-1 ChengShi-1 added Size: 10 A percentage of a sprint. 7 hours. Original size: 10 GREI Re-arch GREI re-architecture-related FY26 Sprint 15 FY26 Sprint 15 (2026-01-14 - 2026-01-28) and removed GREI Re-arch GREI re-architecture-related SPA FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) labels Jan 14, 2026
@ChengShi-1 ChengShi-1 added the SPA label Jan 14, 2026
@coveralls
Copy link

coveralls commented Jan 14, 2026

Coverage Status

coverage: 97.846% (+0.5%) from 97.339%
when pulling 7e79eaf on TemplateUI
into 24bdb22 on develop.

@ChengShi-1 ChengShi-1 moved this to In Progress 💻 in IQSS Dataverse Project Jan 15, 2026
@ChengShi-1 ChengShi-1 self-assigned this Jan 15, 2026
@ekraffmiller ekraffmiller self-assigned this Jan 23, 2026
@ekraffmiller ekraffmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jan 23, 2026
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ChengShi-1 , great work on a big UI feature! I added some comments below.

{tDataset('datasetActionButtons.editDataset.terms')}
</DropdownButtonItem>
</DropdownButton>
<Tooltip placement="top" overlay={t('actions.delete')}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with deleting Templates that have been used in creating a dataset, so for now, the delete button should be disabled in that case.

Copy link
Contributor Author

@ChengShi-1 ChengShi-1 Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used template's usage count to determine whether a template is in use, but I just realize it's incorrect.
When a dataset is deleted, the template’s usage count does not decrease accordingly—it reflects total historical usage rather than current usage. I think we may need a new field to check if the template is used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I found another issue about create dataset with a template IQSS/dataverse#12132

@cmbz cmbz added the FY26 Sprint 16 FY26 Sprint 16 (2026-01-28 - 2026-02-11) label Jan 29, 2026
@ChengShi-1 ChengShi-1 requested a review from Copilot January 30, 2026 20:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 85 out of 86 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! The only thing is a style issue, can the input length for the custom instructions be made to match the metadata field?
For example in the SPA it is longer:

Image

In the JSF the lengths match:

Image

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage passed, approved!

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Feb 6, 2026
@cmbz cmbz added the FY26 Sprint 17 FY26 Sprint 17 (2026-02-11 - 2026-02-25) label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 15 FY26 Sprint 15 (2026-01-14 - 2026-01-28) FY26 Sprint 16 FY26 Sprint 16 (2026-01-28 - 2026-02-11) FY26 Sprint 17 FY26 Sprint 17 (2026-02-11 - 2026-02-25) GREI Re-arch GREI re-architecture-related Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA.Q1.2026.5 Create Template SPA.Q1.2026.6 Manage Template SPA

Projects

Status: Ready for QA ⏩

Development

Successfully merging this pull request may close these issues.

Dataset Templates Integration

4 participants