Open
Conversation
g-saracca
added
GREI Re-arch
github-project-automation
bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
I'm sorry I should have commented on this PR earlier...there is actually some additional logic needed here - if the draft is the only version created for the dataset, it should show the "delete dataset" text, otherwise it should show the delete draft text. |
ekraffmiller
moved this from SPRINT READY
to This Sprint 🏃♀️ 🏃
in IQSS Dataverse Project
ChengShi-1
moved this from This Sprint 🏃♀️ 🏃
to In Progress 💻
in IQSS Dataverse Project
ChengShi-1
added
Size: 3
ChengShi-1
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
ekraffmiller
reviewed
Feb 5, 2026
Contributor
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
Looks good, the text just needs to be changed slightly to match the JSF
| "title": "Delete Dataset", | ||
| "message": "Are you sure you want to delete this dataset? This action cannot be undone.", | ||
| "messageDraft": "Are you sure you want to delete this draft version? You cannot undelete this draft.", | ||
| "messageDataset": "Are you sure you want to delete this dataset? You cannot undelete this dataset.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "messageDataset": "Are you sure you want to delete this dataset? You cannot undelete this dataset.", | |
| "messageDataset": "Are you sure you want to delete this dataset and all of its files? You cannot undelete this dataset.", |
ekraffmiller
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
Co-authored-by: Ellen Kraffmiller <ekraffmiller@hmdc.harvard.edu>
ekraffmiller
approved these changes
Feb 9, 2026
Contributor
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approved
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix wording on delete draft dataset modal.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes or changelog update needed for this change?:
Additional documentation: