Fix Dataset and File Version Summaries #882
Merged
ekraffmiller merged 8 commits intodevelopfrom Nov 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues in the dataset and file version displays, improving the logic for showing version differences and file version links, along with text and UI corrections.
- Enhanced logic for View Details button and file version linking based on deaccessioned status and datafile presence
- Improved display of file access changes (showing "Access: Restricted" instead of "isRestricted: true/false")
- Corrected and standardized error/informational messages across file versions
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/sections/file/file-version/useFileVersionSummaryDescription.tsx | Removed early return for empty summary, allowing component to handle display logic |
| src/sections/file/file-version/FileVersions.tsx | Added logic to disable file version links when datafileId is missing and improved summary display with new conditions |
| src/sections/dataset/dataset-versions/view-difference/DatasetVersionsDifferenceTable.tsx | Enhanced display of file access changes to show human-readable text instead of boolean values |
| src/sections/dataset/dataset-versions/DatasetVersions.tsx | Improved View Details button logic to skip deaccessioned versions when finding previous version |
| src/files/domain/models/FileVersionSummaryInfo.ts | Added datafileId field to FileDifferenceSummary type |
| public/locales/en/file.json | Added "noVersions" message and removed unused "fileNotChange" key |
| public/locales/en/dataset.json | Simplified label from "File Metadata Changed" to "Metadata Changed" |
| tests/* | Added and updated tests for new functionality and removed obsolete tests |
| CHANGELOG.md | Documented changes in this release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ekraffmiller
reviewed
Nov 3, 2025
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, just a few comments 👍
Contributor
Author
|
Hi @ekraffmiller , thanks for your review! I just fixed them in my new commits. |
ekraffmiller
approved these changes
Nov 4, 2025
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approved!
Contributor
Contributor
Contributor
Author
|
@ekraffmiller Thanks for catching them. I solved these two
|
Contributor
|
looks good! merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






What this PR does / why we need it:
Dataset Page:
File Page
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Some screenshots of the issues are #879 here.
Comparing to JSF, see if the issues are solved
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes or changelog update needed for this change?:
yes
Additional documentation: