Add internal environment to deploy workflow#867
Open
ofahimIQSS wants to merge 3 commits intodevelopfrom
Open
Conversation
Contributor
|
Putting this on hold for next year/next release. I sent a couple of runs for this action, and they didn't run even though they are "received" by GH. It seems that this is caused by the secrets that were added to this yaml file:
They are not present in this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change updates .github/workflows/deploy.yml to let us deploy the SPA to our internal environment in addition to qa, beta, and demo.
What changed
Added internal to workflow_dispatch.inputs.environment.options so it shows up in the manual run menu.
Added .env creation step gated by if: github.event.inputs.environment == 'internal'.
Added SCP step to copy the built WAR to the internal host.
Added SSH step to run the Payara deploy on the internal host.
Follow-ups (blocking deploy)
Create the internal environment (or repo-level) secrets used by these new steps:
INTERNAL_DATAVERSE_BACKEND_URL
INTERNAL_OIDC_CLIENT_ID
INTERNAL_OIDC_AUTHORIZATION_ENDPOINT
INTERNAL_OIDC_TOKEN_ENDPOINT
INTERNAL_OIDC_LOGOUT_ENDPOINT
INTERNAL_OIDC_STORAGE_KEY_PREFIX
INTERNAL_PAYARA_INSTANCE_HOST
INTERNAL_PAYARA_INSTANCE_USERNAME
INTERNAL_PAYARA_INSTANCE_SSH_PRIVATE_KEY
Acceptance criteria
Workflow “Run workflow” menu shows internal.
Manual run with environment=internal completes successfully.
SPA is served from the internal host at the expected base path and login works.