Merged
Conversation
ekraffmiller
reviewed
Aug 7, 2025
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
It looks good! Just a few questions.
src/sections/collection/collection-items-panel/useGetAccumulatedItems.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Hello! Please resolve the branch conflicts - thanks! |
Contributor
Author
|
@ekraffmiller could you review again? I solved merge conflicts and made an update to avoid using the recently added picsum external source image with a fixture image. Same changes were applied in Advanced Search UI PR, if you could review that also will be great, thanks! |
ekraffmiller
previously approved these changes
Aug 20, 2025
Contributor
Author
|
@ofahimIQSS, done here also |
ekraffmiller
approved these changes
Aug 25, 2025
Contributor
|
tests passing - merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements the External Search functionality recently added in the backend side.
If there is more than one search service(default is Solr) then a Search Services dropdown is shown in the homepage search bar, as below 👇.
Which issue(s) this PR closes:
Special notes for your reviewer:
Tests are failing, those fixes are done in the release branch, will update this branch with develop once release is merged into it.
Suggestions on how to test this:
This can be tested in the QA environment, as an external search service has been configured in that environment. You can see from this Get search services endpoint result in the QA environment that there is another search service configured there.
The steps could be:
That should be the only thing to test from the SPA, the obtained results depend on the external search service.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: Yes
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A