Skip to content

Update return type of GetMyDataCollectionItems#737

Merged
ofahimIQSS merged 12 commits intodevelopfrom
734-my-data-return-type
Jun 6, 2025
Merged

Update return type of GetMyDataCollectionItems#737
ofahimIQSS merged 12 commits intodevelopfrom
734-my-data-return-type

Conversation

@ekraffmiller
Copy link
Contributor

@ekraffmiller ekraffmiller commented Jun 4, 2025

What this PR does / why we need it:

Updates the frontend use case GetMyDataCollectionItems to use the new return type from this PR IQSS/dataverse-client-javascript#313.

This PR also sets the user search default value to the currently logged in user.

Note: this PR shouldn't be merged until the above js-dataverse PR is merged.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Create some datasets files and collections, check that they display correctly in the Account -> My Data section

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@github-actions github-actions bot added FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) GREI Re-arch GREI re-architecture-related SPA.Q2.1 Account Page: My Data Section labels Jun 4, 2025
@ekraffmiller ekraffmiller added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) GREI Re-arch GREI re-architecture-related and removed GREI Re-arch GREI re-architecture-related FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) labels Jun 4, 2025
@ekraffmiller ekraffmiller marked this pull request as ready for review June 4, 2025 13:49
@ekraffmiller ekraffmiller moved this to Ready for Review ⏩ in IQSS Dataverse Project Jun 4, 2025
@ekraffmiller ekraffmiller marked this pull request as draft June 4, 2025 13:51
@coveralls
Copy link

coveralls commented Jun 4, 2025

Coverage Status

coverage: 97.393% (-0.1%) from 97.488%
when pulling c91d49b on 734-my-data-return-type
into 08188b1 on develop.

@ekraffmiller ekraffmiller marked this pull request as ready for review June 4, 2025 18:11
@g-saracca g-saracca moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jun 5, 2025
@g-saracca g-saracca self-assigned this Jun 5, 2025
g-saracca
g-saracca previously approved these changes Jun 5, 2025
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, approving!
This has some merge conflicts, please solve them and I will approve again, thanks!

One question, what happened about the super users name in the "Search By Username" input that you mentioned yesterday, will you apply that in a separate issue?

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jun 5, 2025
@g-saracca g-saracca moved this from Ready for QA ⏩ to In Review 🔎 in IQSS Dataverse Project Jun 5, 2025
@ekraffmiller
Copy link
Contributor Author

Looks really good, approving! This has some merge conflicts, please solve them and I will approve again, thanks!

One question, what happened about the super users name in the "Search By Username" input that you mentioned yesterday, will you apply that in a separate issue?

Thanks! I added it in this commit: 7b36715

@ekraffmiller
Copy link
Contributor Author

@g-saracca about the branch conflicts, I think it will cause a compile error if I update to the latest js-dataverse version, since the new return type hasn't been merged yet. Can we merge that one first? (IQSS/dataverse-client-javascript#313)

@g-saracca
Copy link
Contributor

@g-saracca about the branch conflicts, I think it will cause a compile error if I update to the latest js-dataverse version, since the new return type hasn't been merged yet. Can we merge that one first? (IQSS/dataverse-client-javascript#313)

Sure! @ofahimIQSS could we QA IQSS/dataverse-client-javascript#313 so we can use it on this PR?

…add logic to TypeFilters.tsx to conditionally display item counts
@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jun 6, 2025
@ofahimIQSS ofahimIQSS self-assigned this Jun 6, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jun 6, 2025
@ofahimIQSS
Copy link
Contributor

Looks good - merging

@ofahimIQSS ofahimIQSS merged commit d984d31 into develop Jun 6, 2025
14 checks passed
@ofahimIQSS ofahimIQSS deleted the 734-my-data-return-type branch June 6, 2025 13:11
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jun 6, 2025
@ofahimIQSS ofahimIQSS removed their assignment Jun 6, 2025
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jun 16, 2025
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q2.1 Account Page: My Data Section

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

GetMyDataCollectionItems use case: update return type

5 participants