Update return type of GetMyDataCollectionItems#737
Conversation
There was a problem hiding this comment.
Looks really good, approving!
This has some merge conflicts, please solve them and I will approve again, thanks!
One question, what happened about the super users name in the "Search By Username" input that you mentioned yesterday, will you apply that in a separate issue?
Thanks! I added it in this commit: 7b36715 |
|
@g-saracca about the branch conflicts, I think it will cause a compile error if I update to the latest js-dataverse version, since the new return type hasn't been merged yet. Can we merge that one first? (IQSS/dataverse-client-javascript#313) |
Sure! @ofahimIQSS could we QA IQSS/dataverse-client-javascript#313 so we can use it on this PR? |
…add logic to TypeFilters.tsx to conditionally display item counts
|
Looks good - merging |
What this PR does / why we need it:
Updates the frontend use case GetMyDataCollectionItems to use the new return type from this PR IQSS/dataverse-client-javascript#313.
This PR also sets the user search default value to the currently logged in user.
Note: this PR shouldn't be merged until the above js-dataverse PR is merged.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Create some datasets files and collections, check that they display correctly in the Account -> My Data section
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: