Skip to content

Collection Page - Sort type as relevance when searching#726

Merged
ofahimIQSS merged 2 commits intodevelopfrom
fix/725-sort-type-relevance
May 29, 2025
Merged

Collection Page - Sort type as relevance when searching#726
ofahimIQSS merged 2 commits intodevelopfrom
fix/725-sort-type-relevance

Conversation

@g-saracca
Copy link
Contributor

@g-saracca g-saracca commented May 29, 2025

What this PR does / why we need it:

We need to sort by relevance (score) when searching in the collection page.
The Sort By dropdown was showing the "Relevance" option as selected but we were not actually sending that parameter to the Search API.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Validate that this fixes the behaviour found in #723

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@g-saracca g-saracca moved this to Ready for Review ⏩ in IQSS Dataverse Project May 29, 2025
@github-actions github-actions bot added FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) GREI Re-arch GREI re-architecture-related SPA.Q2 Not related to any specific Q2 feature labels May 29, 2025
@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels May 29, 2025
@ekraffmiller ekraffmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project May 29, 2025
@ekraffmiller ekraffmiller self-assigned this May 29, 2025
@coveralls
Copy link

coveralls commented May 29, 2025

Coverage Status

coverage: 97.517% (+0.07%) from 97.448%
when pulling 6bee4ce on fix/725-sort-type-relevance
into 9c07513 on develop.

ekraffmiller
ekraffmiller previously approved these changes May 29, 2025
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! approved

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project May 29, 2025
@ekraffmiller ekraffmiller removed their assignment May 29, 2025
@ofahimIQSS ofahimIQSS self-assigned this May 29, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project May 29, 2025
@ofahimIQSS
Copy link
Contributor

tested it with limited data in local - looks good from my point of view. Will merge after test/component completes.

@g-saracca
Copy link
Contributor Author

@ekraffmiller I just made a commit to use latest js-dataverse package

@ofahimIQSS ofahimIQSS moved this from QA ✅ to Ready for Review ⏩ in IQSS Dataverse Project May 29, 2025
@github-project-automation github-project-automation bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project May 29, 2025
@ekraffmiller ekraffmiller removed their assignment May 29, 2025
@ofahimIQSS ofahimIQSS self-assigned this May 29, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project May 29, 2025
@ofahimIQSS
Copy link
Contributor

All good here - merging PR

@ofahimIQSS ofahimIQSS merged commit 92c9786 into develop May 29, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project May 29, 2025
@ofahimIQSS ofahimIQSS deleted the fix/725-sort-type-relevance branch May 29, 2025 18:26
@ofahimIQSS ofahimIQSS removed their assignment May 29, 2025
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q2 Not related to any specific Q2 feature

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Sort by Relevance in SPA Not Functioning as Expected

4 participants