Dataset Deaccession Modal should filter out versions that were deaccessioned#669
Merged
ofahimIQSS merged 7 commits intodevelopfrom May 1, 2025
Merged
Conversation
github-actions
bot
added
bug
ChengShi-1
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
ekraffmiller
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
ekraffmiller
previously approved these changes
Apr 29, 2025
Contributor
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approved!
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
i see some merge conflicts - can you please update :) |
Contributor
|
Ready to merge once PR is reviewed :), no issues found during testing.
|
Contributor
Author
|
@ekraffmiller Hi Ellen, I solved a conflict here so dismiss the review, could you please approve this again? Thanks! |
ChengShi-1
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
ekraffmiller
approved these changes
May 1, 2025
Contributor
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approved!
github-project-automation
bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
ofahimIQSS
deleted the
667-deaccession-modal-fix-form-behavior-and-formatting
branch
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There is not enough border in the modal. This can be fixed by rendering the form group as a column, for example
<Form.Group as={Col}>
If a dataset has a previous dataset version has been deaccessioned, it should not appear in the list of versions that can be deaccessioned.
When the deaccession modal is submitted, there is no loading indicator and button is not disabled while submitting.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Create datasets and make changes on them for forming multiple dataset versions. Deaccession some of them, test if the Deaccession Modal shows the versions being deaccessioned. (it should not show deaccessioned version).
- If only one version is able to be deaccessioned, there is no version list in the modal.
When Deaccession button => deaccession modal => confirmation model, clicked "Yes", there is a spinner for loading status and all buttons are disabled.
Check if the Deaccession button is hidden while the dataset is a draft or is deaccessioned
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: