Dataset page: show deaccession reason and info#664
Merged
ofahimIQSS merged 7 commits intodevelopfrom Apr 30, 2025
Merged
Conversation
g-saracca
requested changes
Apr 28, 2025
Contributor
g-saracca
left a comment
There was a problem hiding this comment.
Just one question and styling suggestion.
src/sections/dataset/dataset-versions/useDatasetVersionSummaryDescription.tsx
Outdated
Show resolved
Hide resolved
g-saracca
reviewed
Apr 28, 2025
src/sections/dataset/dataset-versions/useDatasetVersionSummaryDescription.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
@ChengShi-1 we have some merge conflicts |
Contributor
Author
|
@g-saracca Hi German, thanks for your review. Conflicts merged, and js-dataverse updated to newest alpha version. |
g-saracca
approved these changes
Apr 28, 2025
Contributor
|
not really sure why but I keep getting a blank screen when I navigate to http://localhost:8000/spa |
Contributor
Author
@ofahimIQSS Hi Omer, I check this branch again and don't meet this situation. Could you please re-build the environment again see if it still happen?
|
Contributor
|
looks good, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What this PR does / why we need it:
We are missing showing the deaccession reason in the Dataset page.
Which issue(s) this PR closes:
Special notes for your reviewer:
js-dataverse version should be updated in package.json
waiting for IQSS/dataverse-client-javascript#292
Suggestions on how to test this:
Step 1: Run the Development Environment
Execute npm i.
Navigate with cd packages/design-system && npm i && npm run build.
Return with cd ../../.
Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000/.
Navigate with cd dev-env.
Before running next step, be sure have a fresh unstable dataverse image.
Start the environment using ./run-env.sh unstable.
To verify the environment, visit http://localhost:8000/ and check your local Dataverse installation.
Step 2: Test the feature
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: