Featured Items Use Cases dvObjects extension#316
Conversation
ChengShi-1
left a comment
There was a problem hiding this comment.
In general, do you think it's better to move the featured items out of collections folder, maybe have a separate folder for featured items? because we are supporting dv-objects now
Good point, however I think is ok to keep it inside the collection folder, Featured Items API endpoints are under |
|
@g-saracca Yes, I have no problem to leave it as now. I didn't fully review code changes yet, please give me more time for reviewing other parts of this PR. Thanks! |
Yes of course! It wasn't really Ready for Review yet, but I think is ready now 👍🏼 |
ChengShi-1
left a comment
There was a problem hiding this comment.
Great job! Just some small changes here.
Also, could you make some changes on UseCases.md underupdateCollectionFeaturedItems and getCollectionFeaturedItems to clarify that CollectionFeaturedItem has two types CustomFeaturedItem | DvObjectFeaturedItem
test/functional/collections/UpdateCollectionFeaturedItems.test.ts
Outdated
Show resolved
Hide resolved
test/functional/collections/UpdateCollectionFeaturedItems.test.ts
Outdated
Show resolved
Hide resolved
test/functional/collections/UpdateCollectionFeaturedItems.test.ts
Outdated
Show resolved
Hide resolved
…ured items type dv object collection
…ured items type dv object collection 2
|
@ChengShi-1, all changes applied and related backend PR has been merged 👍🏼 |
|
tests passing - merging. |
What this PR does / why we need it:
Extends the UpdateCollectionFeaturedItems and GetCollectionFeaturedItems use cases to support the API Extension that adds the ability to add featured items type dataverse objects.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Review test code
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A