Skip to content

Featured Items Use Cases dvObjects extension#316

Merged
ofahimIQSS merged 17 commits intodevelopfrom
feat/315-featured-items-dvobjects-extension
Jun 24, 2025
Merged

Featured Items Use Cases dvObjects extension#316
ofahimIQSS merged 17 commits intodevelopfrom
feat/315-featured-items-dvobjects-extension

Conversation

@g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Jun 10, 2025

What this PR does / why we need it:

Extends the UpdateCollectionFeaturedItems and GetCollectionFeaturedItems use cases to support the API Extension that adds the ability to add featured items type dataverse objects.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

Suggestions on how to test this:

Review test code

Is there a release notes update needed for this change?:

N/A

Additional documentation:

N/A

@github-actions github-actions bot added FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) GREI Re-arch GREI re-architecture-related SPA.Q2.3 Featured Items supporting dvobjects labels Jun 10, 2025
@ChengShi-1 ChengShi-1 self-assigned this Jun 16, 2025
@ChengShi-1 ChengShi-1 moved this to Ready for Review ⏩ in IQSS Dataverse Project Jun 16, 2025
@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jun 16, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, do you think it's better to move the featured items out of collections folder, maybe have a separate folder for featured items? because we are supporting dv-objects now

@g-saracca
Copy link
Contributor Author

In general, do you think it's better to move the featured items out of collections folder, maybe have a separate folder for featured items? because we are supporting dv-objects now

Good point, however I think is ok to keep it inside the collection folder, Featured Items API endpoints are under /dataverses/ path. I think also that if I make this change I will need to change lot of things here and in the frontend repo as well. Are you ok with keeping it as it is?

@ChengShi-1
Copy link
Contributor

@g-saracca Yes, I have no problem to leave it as now. I didn't fully review code changes yet, please give me more time for reviewing other parts of this PR. Thanks!

@g-saracca
Copy link
Contributor Author

@g-saracca Yes, I have no problem to leave it as now. I didn't fully review code changes yet, please give me more time for reviewing other parts of this PR. Thanks!

Yes of course! It wasn't really Ready for Review yet, but I think is ready now 👍🏼

Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just some small changes here.
Also, could you make some changes on UseCases.md underupdateCollectionFeaturedItems and getCollectionFeaturedItems to clarify that CollectionFeaturedItem has two types CustomFeaturedItem | DvObjectFeaturedItem

@cmbz cmbz added the FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) label Jun 19, 2025
@g-saracca
Copy link
Contributor Author

@ChengShi-1, all changes applied and related backend PR has been merged 👍🏼

@g-saracca g-saracca removed their assignment Jun 23, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jun 23, 2025
@ofahimIQSS
Copy link
Contributor

tests passing - merging.

@ofahimIQSS ofahimIQSS merged commit 9cd2389 into develop Jun 24, 2025
7 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project Jun 24, 2025
@ofahimIQSS ofahimIQSS deleted the feat/315-featured-items-dvobjects-extension branch June 24, 2025 01:10
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jun 24, 2025
@cmbz cmbz added the FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) label Jul 2, 2025
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) GREI Re-arch GREI re-architecture-related SPA.Q2.3 Featured Items supporting dvobjects

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Extend Featured Items use cases to support dv objects API extension

4 participants