Feat: use case of getFileVersionSummaries#299
Merged
ofahimIQSS merged 9 commits intodevelopfrom May 15, 2025
Merged
Conversation
github-actions
bot
added
FY25 Sprint 22
ChengShi-1
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
g-saracca
requested changes
May 14, 2025
Contributor
g-saracca
left a comment
g-saracca
left a comment
There was a problem hiding this comment.
Looks good! I left some comments.
I think I will review again when related PR gets merged 👍🏼
Contributor
Author
|
Hi @g-saracca , Thanks for review! This PR is ready for review again. I added a transformer to better structure the payload to data model of |
g-saracca
reviewed
May 15, 2025
| this.buildApiEndpoint(this.filesResourceName, 'versionDifferences', fileId), | ||
| true | ||
| ) | ||
| .then((response) => FileVersionSummaryInfoTransformers(response)) |
Contributor
There was a problem hiding this comment.
Hi @ChengShi-1 , just this comment and we are good to go.
Please use the transformers naming convention as in here instead of FileVersionSummaryInfoTransformers.
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
looking good from my end. merging. |
github-project-automation
bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add use case of getFileVersionSummaries
Which issue(s) this PR closes:
Related Dataverse PRs:
IQSS/dataverse#11464 waiting
Special notes for your reviewer:
Commented the part that is affected, will be uncommented after the dataverse PR is merged
Suggestions on how to test this:
Is there a release notes update needed for this change?:
Additional documentation: