Add Deaccession Reason to DatasetVersionsSummary#289
Closed
ChengShi-1 wants to merge 2 commits intodevelopfrom
Closed
Add Deaccession Reason to DatasetVersionsSummary#289ChengShi-1 wants to merge 2 commits intodevelopfrom
ChengShi-1 wants to merge 2 commits intodevelopfrom
Conversation
Contributor
Author
|
I accidentally closed this PR, and reopened the PR, but it led a published version conflict. Original version has been published, and after reopen it, the version number is the same and lead to an error. Creating a new PR to solve this problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
the api endpoint added a {deaccession: {reason: string, url: string }} into the version summary, so the model should be changed accordingly to get the deaccession reason
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes update needed for this change?:
Additional documentation: