-
Notifications
You must be signed in to change notification settings - Fork 395
Fix soap addObject category creation bug #10784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix soap addObject category creation bug #10784
Conversation
|
hi @sKarki999 & @GitHamo you know about the end of the full maintenance for Release 9 at the end of 2025? You should integrate fixes for ILIAS 9 quick before this branch is closed, if the PR code is correct?¿? see the docu |
|
Hi @GitHamo , I would like to request for your review for this. A closer look showed that this file still contains several code paths that rely on PHP’s non-strict typing behavior. To avoid introducing new runtime errors in ILIAS 9, strict typing is therefore postponed for now. However, this is a todo task which has to be addressed in ilias 10+. regards, |
GitHamo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to open a new ticket about safely introducing strict types to ILIAS 10+ or scan for similar issues if it is already introduced
| $object_data["description"], | ||
| $lng->getLangKey(), | ||
| true | ||
| '1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why the related Mantis ticket has to be connected to a new ticket scanning the same file in later versions to see if the types have the same problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your review and sure thing. :)
This PR fixes the issue mentioned in: https://mantis.ilias.de/view.php?id=46688