Skip to content

Conversation

@sKarki999
Copy link
Contributor

This PR fixes the issue mentioned in: https://mantis.ilias.de/view.php?id=46688

@dsstrassner
Copy link
Contributor

hi @sKarki999 & @GitHamo you know about the end of the full maintenance for Release 9 at the end of 2025? You should integrate fixes for ILIAS 9 quick before this branch is closed, if the PR code is correct?¿?

see the docu

@dsstrassner dsstrassner added the php Pull requests that update Php code label Dec 29, 2025
@sKarki999
Copy link
Contributor Author

sKarki999 commented Dec 31, 2025

Hi @GitHamo ,

I would like to request for your review for this.
I have reverted declare(strict_types=1) in class.ilSoapObjectAdministration.php for now.

A closer look showed that this file still contains several code paths that rely on PHP’s non-strict typing behavior.
For example, cloneObject() does not guarantee a strictly typed return value. Enabling strict types at this point would require a more comprehensive refactoring and aligning parameter and return types across the SOAP object administration logic.

To avoid introducing new runtime errors in ILIAS 9, strict typing is therefore postponed for now. However, this is a todo task which has to be addressed in ilias 10+.

regards,
Sagun

Copy link
Contributor

@GitHamo GitHamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to open a new ticket about safely introducing strict types to ILIAS 10+ or scan for similar issues if it is already introduced

$object_data["description"],
$lng->getLangKey(),
true
'1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why the related Mantis ticket has to be connected to a new ticket scanning the same file in later versions to see if the types have the same problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your review and sure thing. :)

@sKarki999 sKarki999 merged commit 84fc529 into ILIAS-eLearning:release_9 Dec 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants