Skip to content

feature/variability improve handling of root constraints with grouping 1552 #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kbirken merged 3 commits into from
Dec 18, 2025
Merged

feature/variability improve handling of root constraints with grouping 1552 #1575

kbirken merged 3 commits into from
Dec 18, 2025

Conversation

@TorstenGoerg
Copy link
Collaborator

@TorstenGoerg TorstenGoerg commented Dec 18, 2025

  • Editor improvements for feature model root constraints.
  • Added repositioning of feature model root constraints on constraint group assignment changes.

This solves #1552.

Torsten Goerg and others added 2 commits December 18, 2025 13:53
@kbirken
Improve handling of root constraints in conjunction with grouping (#1552
f8083ac 
).

Details:
- Editor improvements for feature model root constraints.
- Added repositioning of feature model root constraints on constraint group assignment changes.
- Improved the the root constraints editor according to the review comments.
- Updated CHANGELOG.md.
@TorstenGoerg
Merge branch 'maintenance/mps20241' into 1552-variability-improve-han…
aaed633 
…dling-of-root-constraints-with-grouping
@TorstenGoerg TorstenGoerg requested a review from kbirken December 18, 2025 13:29
@TorstenGoerg TorstenGoerg self-assigned this Dec 18, 2025
kbirken
kbirken previously approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@kbirken kbirken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for detailed comments and discussion see PR #1574.

@kbirken kbirken self-requested a review December 18, 2025 15:01
kbirken
kbirken approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@kbirken kbirken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review status was lost, approving again.

@kbirken kbirken merged commit 8cc1b08 into maintenance/mps20241 Dec 18, 2025
2 checks passed
@kbirken kbirken deleted the feature/variability-improve-handling-of-root-constraints-with-grouping_1552 branch December 18, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbirken kbirken kbirken approved these changes

@arimer arimer Awaiting requested review from arimer arimer is a code owner

@jonaskraemer jonaskraemer Awaiting requested review from jonaskraemer jonaskraemer is a code owner

Assignees

@TorstenGoerg TorstenGoerg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TorstenGoerg @kbirken