Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds filter search functionality to DQ (Data Quality) and Mapping tables to improve user experience when filtering table data. It also includes a minor bug fix for MediaAudits and removes duplicate filters in DQ tables.
- Enables searchable filters on all columns in DQ and Mapping tables by adding
filterSearch: true - Removes duplicate question names from DQ table filters using
Array.from(new Set()) - Fixes MediaAudits default format and adds missing "audio audit" question type
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/modules/SurveyInformation/Mapping/TargetMapping.tsx | Adds filterSearch to all filter-enabled columns |
| src/modules/SurveyInformation/Mapping/SurveyorMapping.tsx | Adds filterSearch to all filter-enabled columns |
| src/modules/MediaAudits/MediaAuditsManage.tsx | Sets default format and adds missing question type |
| src/modules/DQ/DQChecks/DQCheckGroup5.tsx | Adds filterSearch and deduplicates question filters |
| src/modules/DQ/DQChecks/DQCheckGroup4.tsx | Adds filterSearch and deduplicates question filters |
| src/modules/DQ/DQChecks/DQCheckGroup3.tsx | Adds filterSearch and deduplicates question filters |
| src/modules/DQ/DQChecks/DQCheckGroup2.tsx | Adds filterSearch and deduplicates question filters |
| src/modules/DQ/DQChecks/DQCheckGroup1.tsx | Adds filterSearch and deduplicates question filters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| filters: Array.from(new Set(availableModuleNames)).map( | ||
| (name: string) => ({ | ||
| text: name, | ||
| value: name, | ||
| }) | ||
| ), |
There was a problem hiding this comment.
[nitpick] The deduplication logic Array.from(new Set(availableModuleNames)) is inconsistent with the question name filter pattern used in other DQ components. Consider using the same pattern for consistency across all filter implementations.
jeenut27
left a comment
There was a problem hiding this comment.
Tested and works as expected
SS-2158 DQ, Mapping Tables : Add filter search
Ticket
Fixes: https://idinsight.atlassian.net/browse/SS-2158
Description, Motivation and Context
Added filter search option for DQ and Mapping tables.
Removed duplicates from DQ filters.
How Has This Been Tested?
Local
UI Changes
DQ Table:

Mapping Table:
Checklist:
This checklist is a useful reminder of small things that can easily be forgotten.
Put an
xin all the items that apply and remove any items that are not relevant to this PR.