Skip to content

[SS-2158] DQ, Mapping Tables : Add filter search#391

Merged
utkarsh14 merged 1 commit intodevfrom
ui_fixes
Sep 17, 2025
Merged

[SS-2158] DQ, Mapping Tables : Add filter search#391
utkarsh14 merged 1 commit intodevfrom
ui_fixes

Conversation

@utkarsh14
Copy link
Collaborator

@utkarsh14 utkarsh14 commented Aug 28, 2025

SS-2158 DQ, Mapping Tables : Add filter search

Ticket

Fixes: https://idinsight.atlassian.net/browse/SS-2158

Description, Motivation and Context

Added filter search option for DQ and Mapping tables.
Removed duplicates from DQ filters.

How Has This Been Tested?

Local

UI Changes

DQ Table:
image

Mapping Table:

Screenshot 2025-08-28 at 13 35 32

Checklist:

This checklist is a useful reminder of small things that can easily be forgotten.
Put an x in all the items that apply and remove any items that are not relevant to this PR.

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts
  • I have updated the automated tests (if applicable)
  • I have written [good commit messages][1]
  • I have updated the README file (if applicable)
  • I have updated affected documentation (if applicable)

@utkarsh14 utkarsh14 requested review from Copilot and jeenut27 and removed request for jeenut27 August 28, 2025 08:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds filter search functionality to DQ (Data Quality) and Mapping tables to improve user experience when filtering table data. It also includes a minor bug fix for MediaAudits and removes duplicate filters in DQ tables.

  • Enables searchable filters on all columns in DQ and Mapping tables by adding filterSearch: true
  • Removes duplicate question names from DQ table filters using Array.from(new Set())
  • Fixes MediaAudits default format and adds missing "audio audit" question type

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/modules/SurveyInformation/Mapping/TargetMapping.tsx Adds filterSearch to all filter-enabled columns
src/modules/SurveyInformation/Mapping/SurveyorMapping.tsx Adds filterSearch to all filter-enabled columns
src/modules/MediaAudits/MediaAuditsManage.tsx Sets default format and adds missing question type
src/modules/DQ/DQChecks/DQCheckGroup5.tsx Adds filterSearch and deduplicates question filters
src/modules/DQ/DQChecks/DQCheckGroup4.tsx Adds filterSearch and deduplicates question filters
src/modules/DQ/DQChecks/DQCheckGroup3.tsx Adds filterSearch and deduplicates question filters
src/modules/DQ/DQChecks/DQCheckGroup2.tsx Adds filterSearch and deduplicates question filters
src/modules/DQ/DQChecks/DQCheckGroup1.tsx Adds filterSearch and deduplicates question filters

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +98 to +103
filters: Array.from(new Set(availableModuleNames)).map(
(name: string) => ({
text: name,
value: name,
})
),
Copy link

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The deduplication logic Array.from(new Set(availableModuleNames)) is inconsistent with the question name filter pattern used in other DQ components. Consider using the same pattern for consistency across all filter implementations.

Copilot uses AI. Check for mistakes.
@utkarsh14 utkarsh14 requested a review from jeenut27 August 28, 2025 12:40
Copy link
Collaborator

@jeenut27 jeenut27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected

@utkarsh14 utkarsh14 merged commit d2af44e into dev Sep 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments