This is proposed addition for performance data logging #219
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Love <cel@linux.ibm.com>
| start_time = time.time() | ||
| vllm_stream = query_vllm_stream(prompt, docs, llm_endpoint, llm_model, stop_words, max_tokens, temperature, stream, dynamic_chunk_truncation=TRUNCATION) | ||
| request_time = time.time() - start_time | ||
| logger.info(f"Perf data: rag answer time = {request_time}") |
Contributor
There was a problem hiding this comment.
so as discussed in previous PR here :
This rag answer time doesn't reflect the actual time , as it logs as soon as stream object is returned.
But we can refer the llm inferencing time in the llm_utils file for actual timing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated PR with just the sign-off added. Goal was to have the very minimal code changes to give very basic logging info for the initial release. More detailed, code invasive, timings will we worked on for a future release/PR.