Skip to content

Conversation

@allmightyspiff
Copy link
Contributor

also fixes some go1.25 build errors related to 'non-constant format string in call' errors.

In the column config for a table, this change sets WidthMaxEnforcer to a custom function that just returns the string. This change should get tables looking like they did before v1.6.0. If setting this config globally isn't desired let me know and I can change this pull request to make the column config mapping user definable or something along those lines.

Alternatively, being able to configure largeColumnTypes := []string{T("ID"), T("Description")} would be another work around.

Before and After:
image

Tests seem to be failing for a test in the bluemix/authentication/iam/iam_test.go code area that I wasn't sure about. Let me know if I need to fix that test as well.

(py312) ➜  ibm-cloud-cli-sdk git:(termWrapping) ✗ go test ./...
# github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/authentication/iam [github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/authentication/iam.test]
bluemix/authentication/iam/iam_test.go:330:19: undefined: AllowPrintCorrelationID
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix	(cached)
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/authentication	(cached)
FAIL	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/authentication/iam [build failed]
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/authentication/vpc	(cached)
?   	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/configuration	[no test files]
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/configuration/config_helpers	(cached)
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/configuration/core_config	0.018s
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/crn	(cached)
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/endpoints	(cached)
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/http	(cached)
?   	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/models	[no test files]
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/terminal	(cached)
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/trace	(cached)
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/common/downloader	(cached)
?   	github.com/IBM-Cloud/ibm-cloud-cli-sdk/common/file_helpers	[no test files]
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/common/rest	(cached)
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/common/rest/helpers	(cached)
?   	github.com/IBM-Cloud/ibm-cloud-cli-sdk/common/types	[no test files]
?   	github.com/IBM-Cloud/ibm-cloud-cli-sdk/i18n	[no test files]
ok  	github.com/IBM-Cloud/ibm-cloud-cli-sdk/plugin	(cached)
?   	github.com/IBM-Cloud/ibm-cloud-cli-sdk/plugin/pluginfakes	[no test files]
?   	github.com/IBM-Cloud/ibm-cloud-cli-sdk/resources	[no test files]
?   	github.com/IBM-Cloud/ibm-cloud-cli-sdk/testhelpers	[no test files]
?   	github.com/IBM-Cloud/ibm-cloud-cli-sdk/testhelpers/configuration	[no test files]
?   	github.com/IBM-Cloud/ibm-cloud-cli-sdk/testhelpers/matchers	[no test files]
?   	github.com/IBM-Cloud/ibm-cloud-cli-sdk/testhelpers/terminal	[no test files]
FAIL

…rrors related to 'non-constant format string in call' errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant