GH-23: Fix duplicate command "close" by renaming command "close" of ticket cog to "ticket-close" #24
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add try-except in cog loading loop so each cog loads independent of each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A command with the name "close" was registered twice, once in the tickets cog and once in the thread-utils cog. This made the thread-utils cog and every other cog that would load after it fail to load. The command in the tickets cog has been renamed to "ticket-close" to resolve this issue.
Furthermore in relation to cog loading: a try-except statement has been added in the cog loading loop so each cog loads independent of each other, and an error in one cog won't disable every other cog that would load after it.
gh-23