Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an SPI error-recovery mechanism in the SPIDomain (SPI2 model), aiming to abort/reset the SPI peripheral on HAL error callbacks and expose recovery/error state to callers.
Changes:
- Clear the DMA completion
operation_flagpointer after setting it in HAL completion callbacks. - Add
Instance::recover()pluserror_count/was_abortedtracking, and expose recovery helpers viaSPIWrapper. - Invoke recovery from
HAL_SPI_ErrorCallbackand include recovery info in the error report.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
Src/HALAL/Models/SPI/SPI2.cpp |
Clears operation flag after completion; calls recovery from HAL error callback and reports error count. |
Inc/HALAL/Models/SPI/SPI2.hpp |
Adds recovery state to SPIDomain::Instance and new wrapper APIs for abort/recover and error metrics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…-UPV/ST-LIB into fix/SPI/error-recovery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just what the title says