Skip to content

Comments

Fix/SPI/Error Recovery#575

Merged
jorgesg82 merged 10 commits intodevelopmentfrom
fix/SPI/error-recovery
Feb 14, 2026
Merged

Fix/SPI/Error Recovery#575
jorgesg82 merged 10 commits intodevelopmentfrom
fix/SPI/error-recovery

Conversation

@FoniksFox
Copy link
Contributor

Just what the title says

Copilot AI review requested due to automatic review settings February 13, 2026 23:14
@FoniksFox FoniksFox changed the title feat(SPI): Add error recovery mechanism to SPI Fix/SPI/Error Recovery Feb 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces an SPI error-recovery mechanism in the SPIDomain (SPI2 model), aiming to abort/reset the SPI peripheral on HAL error callbacks and expose recovery/error state to callers.

Changes:

  • Clear the DMA completion operation_flag pointer after setting it in HAL completion callbacks.
  • Add Instance::recover() plus error_count / was_aborted tracking, and expose recovery helpers via SPIWrapper.
  • Invoke recovery from HAL_SPI_ErrorCallback and include recovery info in the error report.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
Src/HALAL/Models/SPI/SPI2.cpp Clears operation flag after completion; calls recovery from HAL error callback and reports error count.
Inc/HALAL/Models/SPI/SPI2.hpp Adds recovery state to SPIDomain::Instance and new wrapper APIs for abort/recover and error metrics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jorgesg82 jorgesg82 merged commit 2a76c5b into development Feb 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants