Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the EXTI (external interrupt) service from the previous ExternalInterrupt runtime registration model to a new ST_LIB::EXTIDomain domain-based initialization approach, and updates sensor-side EXTI usage accordingly.
Changes:
- Replaces the old
ExternalInterruptAPI withST_LIB::EXTIDomain(domain entries, build/init, global instance dispatch via HAL EXTI callbacks/IRQs). - Updates
SensorInterruptto read via anEXTIDomain::Instanceinstead of registering an interrupt action itself. - Removes legacy EXTI startup/enable paths from
Sensor::start()andHALAL::common_start(), and wires EXTI into theST-LIB.hppboard domain initialization.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
Src/ST-LIB_LOW/Sensors/SensorInterrupt/SensorInterrupt.cpp |
Switches read path to EXTIDomain::Instance::read() and updates constructors. |
Inc/ST-LIB_LOW/Sensors/SensorInterrupt/SensorInterrupt.hpp |
Changes SensorInterrupt API to accept an EXTIDomain::Instance and stores pointers. |
Src/ST-LIB_LOW/Sensors/Sensor/Sensor.cpp |
Removes EXTI enable loop from Sensor::start(). |
Inc/ST-LIB_LOW/Sensors/Sensor/Sensor.hpp |
Removes stored EXTI id list from Sensor. |
Inc/HALAL/Services/EXTI/EXTI.hpp |
Introduces ST_LIB::EXTIDomain (Device/Entry/Config/Init/Instance) and global instance mapping. |
Src/HALAL/Services/EXTI/EXTI.cpp |
Implements HAL callback + IRQ handlers to dispatch to EXTIDomain instances. |
Src/HALAL/HALAL.cpp |
Removes legacy ExternalInterrupt::start() call from common HAL startup. |
Inc/ST-LIB.hpp |
Adds EXTIDomain into the board build/init pipeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
victor-Lopez25
previously requested changes
Feb 13, 2026
Contributor
victor-Lopez25
left a comment
victor-Lopez25
left a comment
There was a problem hiding this comment.
Check EXTI interrupts from pin 10-15 because they all go to the same interrupt handler
FoniksFox
commented
Feb 13, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
FoniksFox
dismissed
victor-Lopez25’s stale review
Checked it, there are shared IRQHandlers but they can differentiate between pins via bitmasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXTI refactored, it works, I can confirm.