Skip to content

Comments

Nested state now initialize correctly#573

Merged
Cantonplas merged 4 commits intodevelopmentfrom
fix/stata_machine
Feb 12, 2026
Merged

Nested state now initialize correctly#573
Cantonplas merged 4 commits intodevelopmentfrom
fix/stata_machine

Conversation

@Cantonplas
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 12, 2026 17:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the low-level state machine implementation to better support nested state machines by introducing lifecycle hooks (enter/exit/start) in the IStateMachine interface and invoking nested lifecycle transitions alongside parent state transitions.

Changes:

  • Add enter(), exit(), and start() as protected pure-virtual lifecycle methods on IStateMachine, and friend StateMachine to allow invoking them via IStateMachine*.
  • Invoke nested state machine enter()/exit() when the parent transitions between states.
  • Add a start() method that enters the initial state and starts the nested machine for that state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@victor-Lopez25 victor-Lopez25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@oganigl oganigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien

@Cantonplas Cantonplas merged commit 9674174 into development Feb 12, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants