-
Notifications
You must be signed in to change notification settings - Fork 0
chore: add automatic clang-format with pre-commit hooks #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fe0b437
chore: add automatic clang-format with pre-commit hooks
jorgesg82 124b56b
fix: make clang-format config compatible with older versions
jorgesg82 622c922
chore: change hook installer messages to English
jorgesg82 484981f
fix: pin clang-format hook version for deterministic CI
jorgesg82 66ea811
formatted more stuff
jorgesg82 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| BasedOnStyle: LLVM | ||
| IndentWidth: 4 | ||
| TabWidth: 4 | ||
| UseTab: Never | ||
| ColumnLimit: 100 | ||
| PointerAlignment: Left | ||
| AccessModifierOffset: -4 | ||
| SortIncludes: Never | ||
| AllowShortIfStatementsOnASingleLine: false | ||
| AllowShortLoopsOnASingleLine: false | ||
| Cpp11BracedListStyle: true | ||
| BreakBeforeBraces: Attach | ||
| BinPackArguments: false | ||
| BinPackParameters: false | ||
| AllowAllArgumentsOnNextLine: false | ||
| AllowAllParametersOfDeclarationOnNextLine: false | ||
| AlignAfterOpenBracket: BlockIndent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: Format Checks | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| paths: | ||
| - '**.cpp' | ||
| - '**.hpp' | ||
| - '**.c' | ||
| - '**.h' | ||
| - '.pre-commit-config.yaml' | ||
| - '.clang-format' | ||
| - '.github/workflows/format-checks.yml' | ||
|
|
||
| jobs: | ||
| format: | ||
| name: Check code format | ||
| runs-on: ubuntu-24.04 | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
|
|
||
| - name: Install tools | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m pip install pre-commit | ||
| sudo apt-get update | ||
| sudo apt-get install -y clang-format | ||
|
|
||
| - name: Run pre-commit | ||
| run: pre-commit run --all-files --show-diff-on-failure | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| minimum_pre_commit_version: "3.5.0" | ||
| default_install_hook_types: | ||
| - pre-commit | ||
| - pre-push | ||
| repos: | ||
| - repo: https://github.com/pre-commit/mirrors-clang-format | ||
| rev: v17.0.6 | ||
| hooks: | ||
| - id: clang-format | ||
| files: ^(Inc/|Src/|Tests/|tools/).* | ||
| types_or: | ||
| - c | ||
| - c++ | ||
| exclude: ^STM32CubeH7/.* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI installs whatever
clang-formatversion is provided by Ubuntu apt at the time, while local dev machines may have different versions (and the hook useslanguage: system). To avoid inconsistent formatting results, consider pinning clang-format via a pre-commit repo (mirrors-clang-format) or explicitly installing a specificclang-format-<version>package here and documenting the required version locally.