Skip to content

Conversation

@hakan458
Copy link
Contributor

@hakan458 hakan458 commented Jan 30, 2026

Added three new helper functions:

find_all_occurrences - Finds all positions where a substring appears in text
is_word_boundary - Checks if a match is a standalone word (surrounded by non-alphanumeric characters)
find_best_occurrence - Uses a multi-strategy approach:

  • First priority: Prefer word-boundary matches (standalone words like "CA") over partial matches within words (like "CA" in "BOCA")
  • Second priority: If model provides index hints, pick the closest match
  • Third priority: Avoid overlapping with already-assigned entities
  • Fallback: Return first valid occurrence

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.25%. Comparing base (45ac0b1) to head (a62a5df).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
adala/skills/collection/entity_extraction.py 94.73% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   58.78%   59.25%   +0.47%     
==========================================
  Files          55       55              
  Lines        3625     3672      +47     
==========================================
+ Hits         2131     2176      +45     
- Misses       1494     1496       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robot-ci-heartex robot-ci-heartex marked this pull request as draft January 31, 2026 10:06
@matt-bernstein matt-bernstein marked this pull request as ready for review February 2, 2026 14:23
@matt-bernstein
Copy link
Contributor

matt-bernstein commented Feb 2, 2026

/fmt

'/fmt' is an unknown pull-request command.
See '/help'

@matt-bernstein
Copy link
Contributor

matt-bernstein commented Feb 2, 2026

/fm sync

Workflow run

@hakan458 hakan458 merged commit e020a7e into master Feb 2, 2026
16 of 17 checks passed
@hakan458 hakan458 deleted the fb-utc-526 branch February 2, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants