Support interpolation of object #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct behaviour could be the current one, that doing
${ { my: 'object' } }throws an error (str.replace is not a function), but at the very least the error should be mor explicit eg.throw new Error('Bad interpolated value, expected type "string" received type "' + typeof rawText + '"').Initial implementation is to silently serialize the value with JSON.stringify. This is also useful for debugging.
The content that is an object could be
style="${styles}"<div>${myObj}</div>Is outputting the serialized output the correct thing to do? Or should we be failing loud?