Skip to content

Fix CapioFile unlink bug and improve logging #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GlassOfWhiskey merged 4 commits into from
Feb 19, 2026
Merged

Fix CapioFile unlink bug and improve logging #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9325e81
Fixed bug in CapioFile class
Feb 17, 2026
e22b13d
cleanup
Feb 18, 2026
7b9ab74
Add TODO for CLONE_FILES support in manager.hpp
marcoSanti Feb 19, 2026
ed58273
Correct TODO comment in manager.hpp
marcoSanti Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions capio/server/include/storage/manager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,13 @@ class StorageManager {
* @param tid The thread ID.
* @param fd The file descriptor number.
* @param path The path of the file being opened.
* @param register_open Whether this operation should also call open() on the CapioFile
* instance. defaults to true
* TODO: support flag CLONE_FILES which will directly affect the behaviour of
* register_open.
*/
void _addNewFdToStorage(pid_t tid, int fd, const std::filesystem::path &path);
void _addNewFdToStorage(pid_t tid, int fd, const std::filesystem::path &path,
bool register_open);

public:
/**
Expand Down Expand Up @@ -300,4 +305,4 @@ class StorageManager {
void updateDirectory(pid_t tid, const std::filesystem::path &file_path);
};

#endif // CAPIO_STORAGE_MANAGER_HPP
#endif // CAPIO_STORAGE_MANAGER_HPP
9 changes: 6 additions & 3 deletions capio/server/src/storage_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ void StorageManager::clone(const pid_t parent_tid, const pid_t child_tid) {
const auto path = _opened_fd_map[parent_tid][fd]._path;
const auto offset = *_opened_fd_map[parent_tid][fd]._offset;

_addNewFdToStorage(child_tid, fd, path);
_addNewFdToStorage(child_tid, fd, path, false);
_addNewFdToMap(child_tid, fd, path, offset);
}
}
Expand Down Expand Up @@ -276,8 +276,11 @@ void StorageManager::_addNewFdToMap(const pid_t tid, const int fd,
}

void StorageManager::_addNewFdToStorage(const pid_t tid, const int fd,
const std::filesystem::path &path) {
_storage[path].open();
const std::filesystem::path &path,
const bool register_open = true) {
if (register_open) {
_storage[path].open();
}
_storage[path].add_fd(tid, fd);
}

Expand Down