Passing filter parameters to pbDS #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 26, 2022 10:41
Author
|
PS. Please note that I bumped the version down to 4.1, simply not many people use 4.2 yet (I know BioC requires this) and if I'm to have an update muscat as a dependency, I don't want to force them to update to a very recent R version. Of course, not meant to force it to your branch, just prefer to be 4.1 on my fork and wanted to give a heads up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @CATALYST-project,
Thanks for maintaining this super useful package.
I made a small change to the
pbDSfunction so that the parameters used byedgeR::filterByExprandnmadsare modifiable by the user. IMHO, it is essential to be able to control these, and this would be helpful for other users also.Daniel