Skip to content

Conversation

@YKingma99
Copy link

@YKingma99 YKingma99 commented Nov 7, 2025

In the metadata schema and the SHACL byteSize is defined as xsd:nonNegativeInteger, this resulted in SHACL validation error when attempting to post a distribution to the FDP.

Summary by Sourcery

Bug Fixes:

  • Change byteSize rdf_type from xsd:integer to xsd:nonNegativeInteger to resolve SHACL validation errors

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Align RDF type of byteSize property in HRIDistribution to nonNegativeInteger to match metadata schema and fix SHACL validation errors.

Class diagram for updated HRIDistribution byteSize rdf_type

classDiagram
    class HRIDistribution {
        +byte_size: int
        <<rdf_type: xsd:nonNegativeInteger>>
        +applicable_legislation: List[AnyHttpUrl]
    }
    HRIDistribution --|> DCATDistribution
Loading

File-Level Changes

Change Details Files
Updated RDF type for byteSize to nonNegativeInteger.
  • Changed json_schema_extra "rdf_type" value from "xsd:integer" to "xsd:nonNegativeInteger".
sempyro/hri_dcat/hri_distribution.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant