Skip to content

Configure config as volume #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amit-sides wants to merge 7 commits into
base: master
Choose a base branch
from
+12 −5
Open

Configure config as volume #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
80df9a3
Changed config to volume
Jan 5, 2023
37fe0d7
Better image building
Jan 5, 2023
35b0fa1
Even better image building
Jan 5, 2023
84c57ae
Merge remote-tracking branch 'HawkeyeBot/master'
Jan 6, 2023
11658a3
Merge branch 'master' into fixing-config
Jan 6, 2023
99568ef
Changed default config path
Jan 6, 2023
ea21a62
Removed ignored example
Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ dmypy.json

/data
*.json
!*.example.json

*.db.trace.db

Expand Down
8 changes: 6 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
# syntax=docker/dockerfile:1
FROM python:3.8.7-alpine

RUN apk add --no-cache gcc musl-dev linux-headers libffi-dev g++
RUN pip install --upgrade pip
COPY scraper_root /scraper/scraper_root

COPY scraper_root/requirements.txt /scraper/scraper_root/requirements.txt
RUN pip install -r /scraper/scraper_root/requirements.txt
COPY config*.json /scraper/

COPY scraper_root /scraper/scraper_root

WORKDIR /scraper
ENV PYTHONPATH "${PYTHONPATH}:/scraper"
CMD ["python3", "scraper_root/scraper.py"]
0 config.example.json → config/config.example.json
View file
Open in desktop
File renamed without changes.
3 changes: 2 additions & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ services:
scraper:
build: .
environment:
- CONFIG_FILE=/scraper/config.json
- CONFIG_FILE=/config/config.json
- DATABASE_PATH=sqlite:////data/exchanges_db.sqlite
volumes:
- $PWD/data:/data
- $PWD/config:/config
- /etc/timezone:/etc/timezone:ro
- /etc/localtime:/etc/localtime:ro
metabase-app:
Expand Down
3 changes: 2 additions & 1 deletion docker-compose.yml.example-second-dashboard
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ services:
scraper2:
build: .
environment:
- CONFIG_FILE=/scraper/config.json
- CONFIG_FILE=/config/config.json
- DATABASE_PATH=sqlite:////data/exchanges_db.sqlite
volumes:
- $PWD/data:/data
- $PWD/config:/config
- /etc/timezone:/etc/timezone:ro
- /etc/localtime:/etc/localtime:ro
metabase-app2:
Expand Down
2 changes: 1 addition & 1 deletion scraper_root/scraper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
logger = logging.getLogger()

if __name__ == '__main__':
config_file_path = os.environ.get('CONFIG_FILE', 'config.json')
config_file_path = os.environ.get('CONFIG_FILE', '/config/config.json')
logger.info(f"Using config file {config_file_path}")
with open(config_file_path) as config_file:
user_config = hjson.load(config_file, object_hook=lambda d: SimpleNamespace(**d))
Expand Down