解决QuickCut启动问题在macos上；更新.gitignore文件#42
Open
Jaylee89 wants to merge 3 commits intoHaujetZhao:masterfrom
Open
Conversation
pzhlkj6612
reviewed
Sep 30, 2020
Author
|
@HaujetZhao please help to merge it if no concern. |
pzhlkj6612
suggested changes
Mar 15, 2021
Contributor
pzhlkj6612
left a comment
pzhlkj6612
left a comment
There was a problem hiding this comment.
Hi @Jaylee89 , you can remove the Virtualenv things.
Comment on lines
+30
to
+39
| # Environments | ||
| .env | ||
| .venv | ||
| env/ | ||
| venv/ | ||
| ENV/ | ||
| env.bak/ | ||
| venv.bak/ | ||
| Virtualenv/ | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| # Environments | |
| .env | |
| .venv | |
| env/ | |
| venv/ | |
| ENV/ | |
| env.bak/ | |
| venv.bak/ | |
| Virtualenv/ |
I found that the package Virtualenv will auto add .gitignore to its directory starting from version 20.0.21, so it's unnecessary to manually ignore that directory.
v20.0.21 (2020-05-20)
Features - 20.0.21
- Generate ignore file for version control systems to avoid tracking virtual environments by default. Users should remove these files if still want to track. For now we support only git by @ gaborbernat. (#1806)
from: https://virtualenv.pypa.io/en/20.4.2/changelog.html#features-20-0-21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue solve: #29