docs: MetaMask snaps design #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroferreira1
changed the title
pedroferreira1
changed the title
pedroferreira1
moved this from In Progress (WIP)
to In Progress (Done)
in Hathor Network
pedroferreira1
moved this from In Progress (Done)
to In Progress (WIP)
in Hathor Network
pedroferreira1
moved this from In Progress (WIP)
to In Progress (Done)
in Hathor Network
|
|
||
| #### Using wallet service | ||
|
|
||
| The wallet service is still not ready to be used by the MetaMask snaps, especially because it currently still doesn't support nano contracts and its wallet lib in use is old. |
Contributor
There was a problem hiding this comment.
This is about to change though
| After the dApp call above, the MetaMask snaps code will receive and identify each request with a code similar to the one below: | ||
|
|
||
| ``` | ||
| export const onRpcRequest: OnRpcRequestHandler = async ({ |
Contributor
There was a problem hiding this comment.
I think we should normalize the request methods so we can use the handleRpcRequest method of the rpc-lib.
| The handler method will be implemented using the RPC lib already developed for the Reown integration. | ||
|
|
||
| ``` | ||
| // This is a prompt handler expected by the RPC lib when the method requires user confirmation |
Contributor
There was a problem hiding this comment.
Are we going to be able to use the rpc-lib existing Triggers? e.g. CreateNanoContractCreateTokenTxLoadingFinishedTrigger
| ... | ||
| ``` | ||
|
|
||
| The handler method will be implemented using the RPC lib already developed for the Reown integration. |
Contributor
There was a problem hiding this comment.
I think it would be great to better describe how the rpc-lib integration will be done, are we going to use the existing rpcMethods and just listen for triggers in the snap code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Rendered