feat: Added landing page for the application#49
feat: Added landing page for the application#49m-code12 wants to merge 3 commits intoHarshCasper:mainfrom
Conversation
|
@HarshCasper Could you review this pr. |
HarshCasper
left a comment
HarshCasper
left a comment
There was a problem hiding this comment.
Few more changes:
- Shift the
HomePage.jstocomponentssub-directory. - Break down the parts that you are re-using as components
- Remove all the
node_modules. We obviously cannot have them on theclient
Overall, a great work @manikajain11 @m-code12
| <div className="col-lg-2"> | ||
| <h5 className="font-weight-bolder text-dark">COMMUNITY</h5> | ||
| <p className="text-muted">Our Community</p> | ||
| <p className="text-muted">Developers</p> | ||
| <p className="text-muted">Events</p> | ||
| <p className="text-muted">Forum</p> | ||
| </div> | ||
| <div className="col-lg-2 pl-5 ml-5"> | ||
| <h5 className="font-weight-bolder text-dark">SUPPORT</h5> | ||
| <p className="text-muted">Help & Learning</p> | ||
| <p className="text-muted">Troubleshooting</p> | ||
| </div> | ||
| <div className="col-lg-2 pl-5 ml-4"> | ||
| <h5 className="font-weight-bolder text-dark">COMPANY</h5> | ||
| <p className="text-muted">About Us</p> | ||
| <p className="text-muted">Contact Us</p> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Format this block of code with proper indentation
| @@ -0,0 +1,173 @@ | |||
| import React from 'react'; | |||
| import "../node_modules/bootstrap/dist/css/bootstrap.min.css"; | |||
There was a problem hiding this comment.
Can't we import Bootstrap directly?
| <div className="container-fluid mt-2 ml-3"> | ||
| <div className="row"> | ||
| <div className="col-lg-6"> | ||
| <img src="https://user-images.githubusercontent.com/53649201/108606703-8ddf7580-73e1-11eb-9133-e9d62c623eab.PNG" height="400" width="600" /> | ||
| </div> | ||
| <div className="col-lg-6 mt-5"> | ||
| <h1 class="intro mr-4">The simplest way to find and organize notes.</h1> | ||
| <p class="intro-two ml-5 pl-5">AllNotes helps you capture idea and find them fast.</p> | ||
| <button className="btn btn-outline-info mt-3 py-2 px-5 rounded"><strong>Sign up for free</strong></button> | ||
| <p class="intro-three mt-2 pt-1">Already have an account ? <span class="text-pink">Log in.</span></p> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Can you shift this to another component? Since we don't have the Login/Signup functionality ready, we can possibly integrate them when we have it ready. Instead you can have the The simplest way to find and organize notes. AllNotes helps you capture idea and find them fast. content up there as placeholder.
| <h1 class="intro-s1 ml-5">Available on all your devices</h1> | ||
| <p class="intro-s2 ml-2 pl-5 mt-1 pt-2">Sign up today on All Notes for any device and stay in sync - all the time, | ||
| everywhere.</p> | ||
| <button className="btn btn-outline-info mt-3 py-2 px-5 rounded"><strong>Sign up for free</strong></button> |
There was a problem hiding this comment.
Replace this with some placeholder text. Also since we have Sign up for free top above, do we actually need it here?
| <button className="btn btn-outline-info mt-3 py-2 px-5 rounded"><strong>Sign up for free</strong></button> | ||
| </div> | ||
| <div className="col-lg-7 pr-5"> | ||
| <img src="../img2.png" height="400" width="600" /> |
There was a problem hiding this comment.
Replace this with the designs made by Pooja which are available on the design directory. We cannot use someone else's design here 😄
|
Hi @m-code12 Are there any updates on this? |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/allnotes/all-notes/7Jqtvb7kdPYhY8v3SM5P1uEoSKNC |
3 participants
Fixes: #34