Skip to content

Conversation

@tvolk131
Copy link
Contributor

@tvolk131 tvolk131 commented Aug 21, 2025

For Tasks that have no async future/task that helps produce the final message (i.e. tasks of the form Task::perform(async {}, |_| { do_stuff() }), we can simplify to Task::done(do_stuff())

Copilot AI review requested due to automatic review settings August 21, 2025 15:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies synchronous task creation by replacing Task::perform(async {}, |_| { message }) patterns with the more direct Task::done(message) for tasks that don't require any asynchronous computation.

  • Replaces 31 instances of Task::perform(async {}, |_| { ... }) with Task::done(...)
  • Maintains the same functionality while reducing code verbosity
  • Focuses primarily on toast notification messages and simple state updates

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tvolk131
Copy link
Contributor Author

CI appears to be failing due to an http 503 from https://httpbin.org/redirect/1, not from the code changes.

@benthecarman benthecarman merged commit 0b5e342 into HarborWallet:master Aug 25, 2025
1 of 2 checks passed
@tvolk131 tvolk131 deleted the cleanup_sync_tasks branch September 2, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants