fix: circular spinner no longer skips #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the circular spinner animation where it would skip during rotation transitions. The fix involves correcting a mathematical calculation that was using f64::MAX instead of u32::MAX when converting rotation angles.
- Fixes incorrect type casting in rotation calculation that caused spinner skipping
- Removes unnecessary code formatting (braces and line breaks)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| start: now, | ||
| progress: 0.0, | ||
| rotation: rotation.wrapping_add(BASE_ROTATION_SPEED.wrapping_add( | ||
| (f64::from(WRAP_ANGLE / (2.0 * Radians::PI)) * u32::MAX as f64) as u32, |
There was a problem hiding this comment.
The original code used f64::MAX which is much larger than u32::MAX and would cause overflow when cast to u32. The fix correctly uses u32::MAX as f64 to prevent this overflow and ensure proper rotation calculations.
benthecarman
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All that I did here is changing
f64::MAXtou32::MAX as f64. The rest of the diffs are just rust auto-formatting.For details on why this fixes the issue, see this PR where I fixed the iced demo that had the same issue: iced-rs/iced#2617